From 01a0c50d3f73a3f3bb65e511ee1895bb1fa5ab59 Mon Sep 17 00:00:00 2001 From: Daniel Fuchs Date: Fri, 10 Jan 2014 19:48:02 +0100 Subject: [PATCH] 8031525: Logger created in test/tools/jar/UpdateManifest.java might get gc'ed too early The test needs to keep a strong reference on its loggers otherwise the modification of the logger level may only be transient. Reviewed-by: chegar --- jdk/test/tools/jar/UpdateManifest.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/jdk/test/tools/jar/UpdateManifest.java b/jdk/test/tools/jar/UpdateManifest.java index 64897183b57..7a69d96ae53 100644 --- a/jdk/test/tools/jar/UpdateManifest.java +++ b/jdk/test/tools/jar/UpdateManifest.java @@ -39,6 +39,8 @@ public class UpdateManifest { static PrintStream err = System.err; static boolean debug = true; + static final Logger JAR_LOGGER = Logger.getLogger("java.util.jar"); + public static void realMain(String[] args) throws Throwable { if (args.length == 0) { debug = false; @@ -47,7 +49,7 @@ public class UpdateManifest { out = new PrintStream(new FileOutputStream(tmp)); err = out; // Attributes.read() can log a message we don't care to see. - Logger.getLogger("java.util.jar").setLevel(Level.OFF); + JAR_LOGGER.setLevel(Level.OFF); } try { testManifestExistence(); } catch (Throwable t) { unexpected(t); }