From 05be04a12346bd2d992ed954cffce712f0f99430 Mon Sep 17 00:00:00 2001 From: Daniel Fuchs Date: Wed, 2 Nov 2016 14:46:40 +0000 Subject: [PATCH] 8152515: (logging) LogManager.resetLogger should ignore LinkageError LogManager.resetLogger will also ignore errors, but only while shutting down. Reviewed-by: rriggs, dholmes --- .../classes/java/util/logging/LogManager.java | 5 ++ .../logging/LogManager/LinkageErrorTest.java | 83 +++++++++++++++++++ 2 files changed, 88 insertions(+) create mode 100644 jdk/test/java/util/logging/LogManager/LinkageErrorTest.java diff --git a/jdk/src/java.logging/share/classes/java/util/logging/LogManager.java b/jdk/src/java.logging/share/classes/java/util/logging/LogManager.java index e8f96449fae..7e8ec41d84f 100644 --- a/jdk/src/java.logging/share/classes/java/util/logging/LogManager.java +++ b/jdk/src/java.logging/share/classes/java/util/logging/LogManager.java @@ -1449,6 +1449,11 @@ public class LogManager { h.close(); } catch (Exception ex) { // Problems closing a handler? Keep going... + } catch (Error e) { + // ignore Errors while shutting down + if (globalHandlersState != STATE_SHUTDOWN) { + throw e; + } } } } diff --git a/jdk/test/java/util/logging/LogManager/LinkageErrorTest.java b/jdk/test/java/util/logging/LogManager/LinkageErrorTest.java new file mode 100644 index 00000000000..94c1747adc5 --- /dev/null +++ b/jdk/test/java/util/logging/LogManager/LinkageErrorTest.java @@ -0,0 +1,83 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. Oracle designates this + * particular file as subject to the "Classpath" exception as provided + * by Oracle in the LICENSE file that accompanied this code. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ +import java.util.concurrent.CopyOnWriteArrayList; +import java.util.logging.Handler; +import java.util.logging.LogRecord; +import java.util.logging.Logger; + +/** + * @test 8152515 + * @summary Checks that LinkageError are ignored when closing handlers + * during Shutdown. + * @build LinkageErrorTest + * @run main/othervm LinkageErrorTest + */ + +public class LinkageErrorTest { + + public static class TestHandler extends Handler { + + private volatile boolean closed; + public TestHandler() { + INSTANCES.add(this); + } + + @Override + public void publish(LogRecord record) { + } + + @Override + public void flush() { + } + + @Override + public void close() throws SecurityException { + closed = true; + try { + System.out.println(INSTANCES); + } catch (Throwable t) { + // ignore + } + throw new LinkageError(); + } + + @Override + public String toString() { + return super.toString() + "{closed=" + closed + '}'; + } + + private static final CopyOnWriteArrayList INSTANCES + = new CopyOnWriteArrayList<>(); + } + + private static final Logger LOGGER = Logger.getLogger("test"); + private static final Logger GLOBAL = Logger.getGlobal(); + + public static void main(String[] args) { + LOGGER.addHandler(new TestHandler()); + LOGGER.addHandler(new TestHandler()); + GLOBAL.addHandler(new TestHandler()); + } +}