From 05c9eec8d087cbfffed19031a531b72ad18a52cf Mon Sep 17 00:00:00 2001 From: Vicente Romero Date: Mon, 7 Jul 2025 14:56:53 +0000 Subject: [PATCH] 8361214: An anonymous class is erroneously being classify as an abstract class Reviewed-by: liach, mcimadamore --- .../com/sun/tools/javac/comp/Attr.java | 2 +- .../AnonymousLabeledAsAbstractTest.java | 44 +++++++++++++++++++ 2 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 test/langtools/tools/javac/generics/diamond/AnonymousLabeledAsAbstractTest.java diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java b/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java index 8819acbe67e..bb8724f2a60 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java @@ -2833,7 +2833,7 @@ public class Attr extends JCTree.Visitor { resultInfo.checkContext.deferredAttrContext().mode == DeferredAttr.AttrMode.SPECULATIVE; boolean skipNonDiamondPath = false; // Check that class is not abstract - if (cdef == null && !isSpeculativeDiamondInferenceRound && // class body may be nulled out in speculative tree copy + if (cdef == null && !tree.classDeclRemoved() && !isSpeculativeDiamondInferenceRound && // class body may be nulled out in speculative tree copy (clazztype.tsym.flags() & (ABSTRACT | INTERFACE)) != 0) { log.error(tree.pos(), Errors.AbstractCantBeInstantiated(clazztype.tsym)); diff --git a/test/langtools/tools/javac/generics/diamond/AnonymousLabeledAsAbstractTest.java b/test/langtools/tools/javac/generics/diamond/AnonymousLabeledAsAbstractTest.java new file mode 100644 index 00000000000..54c464cc464 --- /dev/null +++ b/test/langtools/tools/javac/generics/diamond/AnonymousLabeledAsAbstractTest.java @@ -0,0 +1,44 @@ +/* + * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8361214 + * @summary An anonymous class is erroneously being classify as an abstract class + * @compile AnonymousLabeledAsAbstractTest.java + */ + +class AnonymousLabeledAsAbstractTest { + abstract class Base {} + abstract class Derived1 extends Base {} + abstract class Derived2 extends Base { + Derived2(Derived1 obj){} + } + abstract class Derived3 extends Base { + Derived3(Derived2 obj){} + } + + Base obj = new Derived2<>(new Derived1<>(){}){}; + Base obj2 = new Derived3(new Derived2<>(new Derived1<>(){}){}){}; + Base obj3 = new Derived3<>(new Derived2<>(new Derived1<>(){}){}){}; +}