infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 12:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

8278207: G1: Tighten verification in G1ResetSkipCompactingClosure

Browse Source 
Reviewed-by: tschatzl, sjohanss
This commit is contained in:
Albert Mingkun Yang 2022-01-11 14:04:52 +00:00
parent c08b2ac34c
commit 08e14c605e
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/hotspot/share/gc/g1/g1FullGCCompactTask.cpp
View File

@ -46,13 +46,23 @@ public:
uint region_index = r->hrm_index();
// Only for skip-compaction regions; early return otherwise.
if (!_collector->is_skip_compacting(region_index)) {
return false;
}
assert(_collector->live_words(region_index) > _collector->scope()->region_compaction_threshold() ||
!r->is_starts_humongous() ||
_collector->mark_bitmap()->is_marked(cast_to_oop(r->bottom())),
"must be, otherwise reclaimed earlier");
#ifdef ASSERT
if (r->is_humongous()) {
oop obj = cast_to_oop(r->humongous_start_region()->bottom());
assert(_collector->mark_bitmap()->is_marked(obj), "must be live");
} else if (r->is_open_archive()) {
bool is_empty = (_collector->live_words(r->hrm_index()) == 0);
assert(!is_empty, "should contain at least one live obj");
} else if (r->is_closed_archive()) {
// should early-return above
ShouldNotReachHere();
} else {
assert(_collector->live_words(region_index) > _collector->scope()->region_compaction_threshold(),
"should be quite full");
}
#endif
r->reset_skip_compacting_after_full_gc();
return false;
}