From 0ec4944be78146ee5e5f3c504f43aa2cee4a470e Mon Sep 17 00:00:00 2001 From: Vicente Romero Date: Thu, 8 Nov 2018 18:23:52 -0500 Subject: [PATCH] 8211450: UndetVar::dup is not copying the kind field to the duplicated instance Reviewed-by: mcimadamore --- .../com/sun/tools/javac/code/Type.java | 3 +- .../javac/T8211450/ThrownTypeVarTest.java | 49 +++++++++++++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) create mode 100644 test/langtools/tools/javac/T8211450/ThrownTypeVarTest.java diff --git a/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java b/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java index 7c63b82ac85..fda1a47a181 100644 --- a/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java +++ b/src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java @@ -1,5 +1,5 @@ /* - * Copyright (c) 1999, 2017, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 1999, 2018, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -2020,6 +2020,7 @@ public abstract class Type extends AnnoConstruct implements TypeMirror { for (IncorporationAction action : incorporationActions) { uv2.incorporationActions.add(action.dup(uv2)); } + uv2.kind = kind; } @Override diff --git a/test/langtools/tools/javac/T8211450/ThrownTypeVarTest.java b/test/langtools/tools/javac/T8211450/ThrownTypeVarTest.java new file mode 100644 index 00000000000..a1db2f4c3a7 --- /dev/null +++ b/test/langtools/tools/javac/T8211450/ThrownTypeVarTest.java @@ -0,0 +1,49 @@ +/* + * Copyright (c) 2018, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8211450 + * @summary UndetVar::dup is not copying the kind field to the duplicated instance + * @compile ThrownTypeVarTest.java + */ + +import java.io.*; + +public class ThrownTypeVarTest { + void repro() throws IOException { + when(f(any())); + } + + interface MyInt {} + + T2 f(MyInt g) throws IOException, E2 { + return null; + } + + static T3 any() { + return null; + } + + static void when(T4 methodCall) {} +}