infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-05-05 03:05:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

8350916: Remove misleading warning "Cannot dump shared archive while using shared archive"

Browse Source 
Reviewed-by: ccheung
This commit is contained in:
Ioi Lam 2025-03-02 03:43:46 +00:00
parent 785e7b47e0
commit 157e5ad4a3
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/hotspot/share/cds/cdsConfig.cpp
View File

@ -68,9 +68,16 @@ int CDSConfig::get_status() {
void CDSConfig::initialize() {
if (is_dumping_static_archive() && !is_dumping_final_static_archive()) {
if (RequireSharedSpaces) {
warning("Cannot dump shared archive while using shared archive");
}
// Note: -Xshare and -XX:AOTMode flags are mutually exclusive.
// - Classic workflow: -Xshare:on and -Xshare:dump cannot take effect at the same time.
// - JEP 483 workflow: -XX:AOTMode:record and -XX:AOTMode=on cannot take effect at the same time.
// So we can never come to here with RequireSharedSpaces==true.
assert(!RequireSharedSpaces, "sanity");
// If dumping the classic archive, or making an AOT training run (dumping a preimage archive),
// for sanity, parse all classes from classfiles.
// TODO: in the future, if we want to support re-training on top of an existing AOT cache, this
// needs to be changed.
UseSharedSpaces = false;
}