infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 03:58:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

8365699: Remove jdk.internal.javac.PreviewFeature.Feature enum values for features finalized in Java 25 or earlier

Browse Source 
Reviewed-by: vromero, liach
This commit is contained in:
Jaikiran Pai 2025-11-06 04:42:20 +00:00
parent d5831ed866
commit 188da51f30
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java
View File

@ -64,18 +64,27 @@ public @interface PreviewFeature {
* Values should be annotated with the feature's {@code JEP}.
*/
public enum Feature {
// while building the interim javac, the ClassReader will produce a warning when loading a class
// keeping the constant of a feature that has been integrated or dropped, serves the purpose of muting such warnings.
// The JDK build process involves creating an interim javac which is then
// used to compile the rest of the JDK. The jdk.internal.javac.PreviewFeature
// annotation from the current sources is used when compiling interim javac.
// That's because the javac APIs of the current sources may be annotated with
// this annotation and they may be using the enum constants of the current sources.
// Furthermore, when compiling interim javac, the class files from the bootstrap JDK get
// used and those may also contain the PreviewFeature annotation. However, they may be
// using the enum constants of the bootstrap JDK's PreviewFeature annotation.
// If javac sees an annotation with an unknown enum constant, it produces a warning,
// and that in turn fails the build.
// So, in the current sources, we need to preserve the PreviewFeature enum constants
// for as long as the interim javac build needs it. As a result, we retain PreviewFeature
// enum constants for preview features that are present in the bootstrap JDK.
// Older constants can be removed.
//
// For example, Class-File API became final in JDK 24. As soon as JDK 23 was dropped as
// the bootstrap JDK, the CLASSFILE_API enum constant became eligible for removal.
//---
IMPLICIT_CLASSES, //to be removed when boot JDK is 25
SCOPED_VALUES,
@JEP(number=505, title="Structured Concurrency", status="Fifth Preview")
STRUCTURED_CONCURRENCY,
CLASSFILE_API,
STREAM_GATHERERS,
MODULE_IMPORTS, //remove when the boot JDK is JDK 25
KEY_DERIVATION, //remove when the boot JDK is JDK 25
@JEP(number = 502, title = "Stable Values", status = "Preview")
STABLE_VALUES,
@JEP(number=470, title="PEM Encodings of Cryptographic Objects", status="Preview")