infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-03-29 09:10:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

8243291: Shenandoah: no need to retire TLABs at Init Update Refs

Browse Source 
Reviewed-by: rkennke
This commit is contained in:
Aleksey Shipilev 2020-04-22 15:19:52 +02:00
parent 91d204780d
commit 1ba7cf7dd6
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
View File

@ -1524,7 +1524,11 @@ void ShenandoahHeap::op_final_mark() {
assert_pinned_region_status();
}
// Force the threads to reacquire their TLABs outside the collection set.
// Retire the TLABs, which will force threads to reacquire their TLABs after the pause.
// This is needed for two reasons. Strong one: new allocations would be with new freeset,
// which would be outside the collection set, so no cset writes would happen there.
// Weaker one: new allocations would happen past update watermark, and so less work would
// be needed for reference updates (would update the large filler instead).
{
ShenandoahGCSubPhase phase(ShenandoahPhaseTimings::retire_tlabs);
make_parsable(true);
@ -2449,10 +2453,6 @@ void ShenandoahHeap::op_init_updaterefs() {
{
ShenandoahGCSubPhase phase(ShenandoahPhaseTimings::init_update_refs_prepare);
make_parsable(true);
// Reset iterator.
_update_refs_iterator.reset();
}