8371381: [Shenandoah] Setting ergo flags should use FLAG_SET_ERGO

Reviewed-by: xpeng, wkemper, ysr, cslucas
This commit is contained in:
Rui Li 2025-11-13 18:01:58 +00:00 committed by Xiaolong Peng
parent bfc048aba6
commit 2199b5fef4
2 changed files with 8 additions and 4 deletions

View File

@ -36,7 +36,7 @@
do { \
if (FLAG_IS_DEFAULT(name) && (name)) { \
log_info(gc)("Heuristics ergonomically sets -XX:-" #name); \
FLAG_SET_DEFAULT(name, false); \
FLAG_SET_ERGO(name, false); \
} \
} while (0)
@ -44,7 +44,7 @@
do { \
if (FLAG_IS_DEFAULT(name) && !(name)) { \
log_info(gc)("Heuristics ergonomically sets -XX:+" #name); \
FLAG_SET_DEFAULT(name, true); \
FLAG_SET_ERGO(name, true); \
} \
} while (0)
@ -52,7 +52,7 @@
do { \
if (FLAG_IS_DEFAULT(name)) { \
log_info(gc)("Heuristics ergonomically sets -XX:" #name "=" #value); \
FLAG_SET_DEFAULT(name, value); \
FLAG_SET_ERGO(name, value); \
} \
} while (0)

View File

@ -29,6 +29,7 @@
#include "gc/shenandoah/shenandoahHeap.inline.hpp"
#include "logging/log.hpp"
#include "logging/logTag.hpp"
#include "runtime/globals_extension.hpp"
#include "runtime/java.hpp"
void ShenandoahPassiveMode::initialize_flags() const {
@ -38,7 +39,10 @@ void ShenandoahPassiveMode::initialize_flags() const {
// No need for evacuation reserve with Full GC, only for Degenerated GC.
if (!ShenandoahDegeneratedGC) {
SHENANDOAH_ERGO_OVERRIDE_DEFAULT(ShenandoahEvacReserve, 0);
if (FLAG_IS_DEFAULT(ShenandoahEvacReserve)) {
log_info(gc)("Heuristics sets -XX:ShenandoahEvacReserve=0");
FLAG_SET_DEFAULT(ShenandoahEvacReserve, 0);
}
}
// Disable known barriers by default.