infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 03:58:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove _active_alloc_region flag and directly use field _atomic_top to determine atomic alloc region

Browse Source
This commit is contained in:
Xiaolong Peng 2026-01-21 15:13:13 -08:00
parent 567bc9f3d7
commit 27dafac753
2 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp
View File

@ -90,7 +90,6 @@ ShenandoahHeapRegion::ShenandoahHeapRegion(HeapWord* start, size_t index, bool c
SpaceMangler::mangle_region(MemRegion(_bottom, _end));
}
_recycling.unset();
_active_alloc_region.unset();
}
void ShenandoahHeapRegion::report_illegal_transition(const char *method) {

13
src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp
View File

@ -270,8 +270,6 @@ private:
bool _needs_bitmap_reset;
ShenandoahSharedFlag _active_alloc_region; // Flag indicates that whether the region is an active alloc region.
public:
ShenandoahHeapRegion(HeapWord* start, size_t index, bool committed);
@ -563,11 +561,9 @@ public:
inline void set_active_alloc_region() {
shenandoah_assert_heaplocked();
assert(_active_alloc_region.is_unset(), "Must be");
// Sync _top to _atomic_top before setting _active_alloc_region flag to prepare for CAS allocation
assert(atomic_top() == nullptr, "Must be");
// Sync _top to _atomic_top to set the region as an active atomic alloc region
AtomicAccess::release_store(&_atomic_top, top<false>());
_active_alloc_region.set();
}
// Unset a heap region as active alloc region,
@ -593,13 +589,12 @@ public:
}
current_atomic_top = prior_atomic_top;
}
OrderAccess::fence();
assert(top<false>() == current_atomic_top, "Value of _atomic_top must have synced to _top.");
_active_alloc_region.unset();
assert(top<false>() == current_atomic_top, "Value of _atomic_top must have synced to _top");
}
inline bool is_active_alloc_region() const {
return _active_alloc_region.is_set();
// region is an active atomic alloc region if the atomic top is set
return atomic_top() != nullptr;
}
private: