infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 03:58:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

8373105: Test tools/jpackage/share/AsyncTest.java failed: problem running hdiutil

Browse Source 
Reviewed-by: asemenyuk
This commit is contained in:
Alexander Matveev 2025-12-19 23:19:27 +00:00
parent 0a70da46f6
commit 2d09284060
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacHelper.java
View File

@ -81,12 +81,18 @@ public final class MacHelper {
ThrowingConsumer<Path, ? extends Exception> consumer) {
cmd.verifyIsOfType(PackageType.MAC_DMG);
// Mount DMG under random temporary folder to avoid collisions when
// mounting DMG with same name asynchroniusly multiple times.
// See JDK-8373105. "hdiutil" does not handle such cases very good.
final var mountRoot = TKit.createTempDirectory("mountRoot");
// Explode DMG assuming this can require interaction, thus use `yes`.
String attachCMD[] = {
"sh", "-c",
String.join(" ", "yes", "|", "/usr/bin/hdiutil", "attach",
JPackageCommand.escapeAndJoin(
cmd.outputBundle().toString()), "-plist")};
JPackageCommand.escapeAndJoin(cmd.outputBundle().toString()),
"-mountroot", PathUtils.normalizedAbsolutePathString(mountRoot),
"-nobrowse", "-plist")};
RetryExecutor attachExecutor = new RetryExecutor();
try {
// 10 times with 6 second delays.