8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests

Reviewed-by: lmesnik, dholmes
This commit is contained in:
SendaoYan 2025-12-15 14:18:46 +00:00
parent 1f47294cd3
commit 34f241317e
11 changed files with 12 additions and 30 deletions

View File

@ -54,9 +54,7 @@ public class DockerBasicTest {
testHelloDocker();
testJavaVersionWithCgMounts();
} finally {
if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
DockerTestUtils.removeDockerImage(imageNameAndTag);
}
DockerTestUtils.removeDockerImage(imageNameAndTag);
}
}

View File

@ -57,9 +57,7 @@ public class ShareTmpDir {
try {
test();
} finally {
if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
DockerTestUtils.removeDockerImage(imageName);
}
DockerTestUtils.removeDockerImage(imageName);
}
}

View File

@ -85,9 +85,7 @@ public class TestCPUAwareness {
}
} finally {
if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
DockerTestUtils.removeDockerImage(imageName);
}
DockerTestUtils.removeDockerImage(imageName);
}
}

View File

@ -63,9 +63,7 @@ public class TestLimitsUpdating {
try {
testLimitUpdates();
} finally {
if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
DockerTestUtils.removeDockerImage(imageName);
}
DockerTestUtils.removeDockerImage(imageName);
}
}

View File

@ -102,9 +102,7 @@ public class TestMemoryAwareness {
testMetricsSwapExceedingPhysical();
testContainerMemExceedsPhysical();
} finally {
if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
DockerTestUtils.removeDockerImage(imageName);
}
DockerTestUtils.removeDockerImage(imageName);
}
}

View File

@ -63,9 +63,7 @@ public class TestPids {
try {
testPids();
} finally {
if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
DockerTestUtils.removeDockerImage(imageName);
}
DockerTestUtils.removeDockerImage(imageName);
}
}

View File

@ -81,9 +81,7 @@ public class TestDockerMemoryMetrics {
testMemorySoftLimit("500m","200m");
} finally {
if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
DockerTestUtils.removeDockerImage(imageName);
}
DockerTestUtils.removeDockerImage(imageName);
}
}

View File

@ -53,9 +53,7 @@ public class TestGetFreeSwapSpaceSize {
"150M", Integer.toString(0)
);
} finally {
if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
DockerTestUtils.removeDockerImage(imageName);
}
DockerTestUtils.removeDockerImage(imageName);
}
}

View File

@ -62,9 +62,7 @@ public class TestLimitsUpdating {
try {
testLimitUpdates();
} finally {
if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
DockerTestUtils.removeDockerImage(imageName);
}
DockerTestUtils.removeDockerImage(imageName);
}
}

View File

@ -59,9 +59,7 @@ public class TestPidsLimit {
testPidsLimit("2000");
testPidsLimit("Unlimited");
} finally {
if (!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
DockerTestUtils.removeDockerImage(imageName);
}
DockerTestUtils.removeDockerImage(imageName);
}
}

View File

@ -291,7 +291,9 @@ public class DockerTestUtils {
* @throws Exception
*/
public static void removeDockerImage(String imageNameAndTag) throws Exception {
if(!DockerTestUtils.RETAIN_IMAGE_AFTER_TEST) {
execute(Container.ENGINE_COMMAND, "rmi", "--force", imageNameAndTag);
}
}