infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-03-16 10:53:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

8351374: Improve comment about queue.remove timeout in CleanerImpl.run

Browse Source 
Reviewed-by: rriggs, shade
This commit is contained in:
Kim Barrett 2025-03-18 18:59:42 +00:00
parent a3540be502
commit 355b2f3bdd
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2015, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2015, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -135,8 +135,14 @@ public final class CleanerImpl implements Runnable {
mlThread.eraseThreadLocals();
}
try {
// Wait for a Ref, with a timeout to avoid getting hung
// due to a race with clear/clean
// Wait for a Ref, with a timeout to avoid a potential hang.
// The Cleaner may become unreachable and its cleanable run,
// while there are registered cleanables for other objects.
// If the application explicitly calls clean() on all remaining
// Cleanables, there won't be any references enqueued to unblock
// this. Using a timeout is simpler than unblocking this by
// having cleaning of the last registered cleanable enqueue a
// dummy reference.
Cleanable ref = (Cleanable) queue.remove(60 * 1000L);
if (ref != null) {
ref.clean();