infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-02-20 15:25:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN"

Browse Source 
Reviewed-by: cjplummer, amenkov
This commit is contained in:
Kevin Walls 2022-08-20 14:20:29 +00:00
parent 37c0a13647
commit 3601e30df7
1 changed files with 11 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
test/hotspot/jtreg/vmTestbase/nsk/monitoring/MemoryPoolMBean/isUsageThresholdExceeded/isexceeded001.java
View File

@ -37,7 +37,7 @@ import javax.management.openmbean.CompositeData;
public class isexceeded001 {
private static boolean testFailed = false;
private static final int INCREMENT = 100 * 1024; // 100kb
private static final int INCREMENT = 100 * 1024 * 1024 ; // 100MB
public static void main(String[] argv) {
System.exit(Consts.JCK_STATUS_BASE + run(argv, System.out));
}
@ -54,17 +54,20 @@ public class isexceeded001 {
for (int i = 0; i < pools.size(); i++) {
Object pool = pools.get(i);
log.display(i + " pool " + monitor.getName(pool) + " of type: " + monitor.getType(pool));
if (!monitor.isUsageThresholdSupported(pool)) {
log.display(" does not support usage thresholds: skip");
// Skip non-heap pools, as they have unpredictable behaviour, or if
// usage threshold not supported:
if (monitor.getType(pool) != MemoryType.HEAP || !monitor.isUsageThresholdSupported(pool)) {
continue;
}
log.display(i + " pool " + monitor.getName(pool) + " of type: " + monitor.getType(pool));
// Set a threshold that is greater than used value
MemoryUsage usage = monitor.getUsage(pool);
MemoryUsage peakUsage = monitor.getPeakUsage(pool);
boolean isExceeded = monitor.isUsageThresholdExceeded(pool);
long used = usage.getUsed();
long max = usage.getMax();
long peakUsed = peakUsage.getUsed();
long threshold = used + 1;
if ( (max > -1) && (threshold > max) ) {
@ -76,6 +79,7 @@ public class isexceeded001 {
monitor.setUsageThreshold(pool, threshold);
log.display(" used value is " + used + " max is " + max + " isExceeded = " + isExceeded);
log.display("peak used value is " + peakUsed);
log.display(" threshold set to " + threshold);
log.display(" threshold count " + monitor.getUsageThresholdCount(pool));
@ -95,24 +99,16 @@ public class isexceeded001 {
// Fetch usage information: use peak usage in comparisons below, in case usage went up and then down.
// Log used and peak used in case of failure.
usage = monitor.getUsage(pool);
MemoryUsage peakUsage = monitor.getPeakUsage(pool);
peakUsage = monitor.getPeakUsage(pool);
used = usage.getUsed();
max = usage.getMax();
long peakUsed = usage.getUsed();
long peakMax = usage.getMax();
peakUsed = peakUsage.getUsed();
log.display(" used value is " + used + " max is " + max + " isExceeded = " + isExceeded);
log.display("peak used value is " + peakUsed + " peak max is " + peakMax);
log.display(" threshold set to " + threshold);
log.display("peak used value is " + peakUsed);
long thresholdCount = monitor.getUsageThresholdCount(pool);
log.display(" threshold count " + thresholdCount);
// Test can be imprecise, particularly with CodeHeap: usage changes outside our control.
if (thresholdCount > 0 && monitor.getType(pool) != MemoryType.HEAP) {
log.display(" thresholdCount increasing outside our control for non-heap Pool: skip");
continue;
}
// If peak used value is less than threshold, then isUsageThresholdExceeded()
// is expected to return false.
if (peakUsed < threshold && isExceeded) {