infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 03:58:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

8364657: Crash for SecureRandom.generateSeed(0) on Windows x86-64

Browse Source 
Co-authored-by: Jaikiran Pai <jpai@openjdk.org>
Reviewed-by: weijun, jpai
This commit is contained in:
Shawn M Emery 2025-09-23 07:54:51 +00:00 committed by Jaikiran Pai
parent 47ed1a8d17
commit 360b6af1b1
2 changed files with 50 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -366,7 +366,11 @@ JNIEXPORT jbyteArray JNICALL Java_sun_security_mscapi_PRNG_generateSeed
} else {
if (length > 0) {
/*
* seed could be NULL here when SecureRandom.generateSeed() is
* called with a length of zero.
*/
if ((length > 0) || (seed == NULL)) {
seed = env->NewByteArray(length);
if (seed == NULL) {
__leave;

44
test/jdk/java/security/SecureRandom/TestStrong.java Normal file
View File

@ -0,0 +1,44 @@
/*
* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import java.security.SecureRandom;
import java.util.Arrays;
/*
* @test
* @bug 8364657
* @summary verify the behavior of SecureRandom instance returned by
* SecureRandom.getInstanceStrong()
* @run main TestStrong
*/
public class TestStrong {
public static void main(String[] args) throws Exception {
final SecureRandom random = SecureRandom.getInstanceStrong();
System.out.println("going to generate random seed using " + random);
final byte[] seed = random.generateSeed(0);
System.out.println("random seed generated");
System.out.println("seed: " + Arrays.toString(seed));
}
}