8362587: Sort share/oops includes

Reviewed-by: shade, dholmes

src/hotspot/share/oops/compressedOops.cpp

@@ -22,6 +22,7 @@
  *
  */
 
+#include "gc/shared/collectedHeap.hpp"
 #include "logging/log.hpp"
 #include "logging/logStream.hpp"
 #include "memory/memRegion.hpp"
@@ -29,7 +30,6 @@
 #include "memory/resourceArea.hpp"
 #include "memory/universe.hpp"
 #include "oops/compressedOops.hpp"
-#include "gc/shared/collectedHeap.hpp"
 #include "runtime/arguments.hpp"
 #include "runtime/globals.hpp"
 

src/hotspot/share/oops/compressedOops.hpp

@@ -29,6 +29,7 @@
 #include "memory/memRegion.hpp"
 #include "oops/oopsHierarchy.hpp"
 #include "utilities/globalDefinitions.hpp"
+
 #include <type_traits>
 
 class outputStream;

src/hotspot/share/oops/cpCache.cpp

@@ -31,8 +31,8 @@
 #include "classfile/systemDictionaryShared.hpp"
 #include "classfile/vmClasses.hpp"
 #include "code/codeCache.hpp"
-#include "interpreter/bytecodeStream.hpp"
 #include "interpreter/bytecodes.hpp"
+#include "interpreter/bytecodeStream.hpp"
 #include "interpreter/interpreter.hpp"
 #include "interpreter/linkResolver.hpp"
 #include "interpreter/rewriter.hpp"

src/hotspot/share/oops/fieldInfo.cpp

@@ -22,8 +22,8 @@
  *
  */
 
-#include "memory/resourceArea.hpp"
 #include "cds/cdsConfig.hpp"
+#include "memory/resourceArea.hpp"
 #include "oops/fieldInfo.inline.hpp"
 #include "runtime/atomic.hpp"
 #include "utilities/packedTable.hpp"

src/hotspot/share/oops/fieldStreams.hpp

@@ -25,8 +25,8 @@
 #ifndef SHARE_OOPS_FIELDSTREAMS_HPP
 #define SHARE_OOPS_FIELDSTREAMS_HPP
 
-#include "oops/instanceKlass.hpp"
 #include "oops/fieldInfo.hpp"
+#include "oops/instanceKlass.hpp"
 #include "runtime/fieldDescriptor.hpp"
 
 // The is the base class for iteration over the fields array

src/hotspot/share/oops/instanceKlass.cpp

@@ -50,8 +50,8 @@
 #include "interpreter/rewriter.hpp"
 #include "jvm.h"
 #include "jvmtifiles/jvmti.h"
-#include "logging/log.hpp"
 #include "klass.inline.hpp"
+#include "logging/log.hpp"
 #include "logging/logMessage.hpp"
 #include "logging/logStream.hpp"
 #include "memory/allocation.inline.hpp"
@@ -61,8 +61,8 @@
 #include "memory/oopFactory.hpp"
 #include "memory/resourceArea.hpp"
 #include "memory/universe.hpp"
-#include "oops/fieldStreams.inline.hpp"
 #include "oops/constantPool.hpp"
+#include "oops/fieldStreams.inline.hpp"
 #include "oops/instanceClassLoaderKlass.hpp"
 #include "oops/instanceKlass.inline.hpp"
 #include "oops/instanceMirrorKlass.hpp"
@@ -78,8 +78,8 @@
 #include "prims/jvmtiThreadState.hpp"
 #include "prims/methodComparator.hpp"
 #include "runtime/arguments.hpp"
-#include "runtime/deoptimization.hpp"
 #include "runtime/atomic.hpp"
+#include "runtime/deoptimization.hpp"
 #include "runtime/fieldDescriptor.inline.hpp"
 #include "runtime/handles.inline.hpp"
 #include "runtime/javaCalls.hpp"

src/hotspot/share/oops/instanceOop.hpp

@@ -26,6 +26,7 @@
 #define SHARE_OOPS_INSTANCEOOP_HPP
 
 #include "oops/oop.hpp"
+
 #include <type_traits>
 
 // An instanceOop is an instance of a Java Class

src/hotspot/share/oops/klassVtable.cpp

@@ -40,8 +40,8 @@
 #include "oops/objArrayOop.hpp"
 #include "oops/oop.inline.hpp"
 #include "runtime/flags/flagSetting.hpp"
-#include "runtime/java.hpp"
 #include "runtime/handles.inline.hpp"
+#include "runtime/java.hpp"
 #include "runtime/safepointVerifiers.hpp"
 #include "utilities/copy.hpp"
 

src/hotspot/share/oops/markWord.inline.hpp

@@ -25,9 +25,10 @@
 #ifndef SHARE_OOPS_MARKWORD_INLINE_HPP
 #define SHARE_OOPS_MARKWORD_INLINE_HPP
 
-#include "oops/compressedOops.inline.hpp"
 #include "oops/markWord.hpp"
 
+#include "oops/compressedOops.inline.hpp"
+
 narrowKlass markWord::narrow_klass() const {
 #ifdef _LP64
   assert(UseCompactObjectHeaders, "only used with compact object headers");

src/hotspot/share/oops/metadata.cpp

@@ -22,8 +22,8 @@
  *
  */
 
-#include "oops/metadata.hpp"
 #include "memory/resourceArea.hpp"
+#include "oops/metadata.hpp"
 #include "prims/jvmtiRedefineClasses.hpp"
 
 void Metadata::set_on_stack(const bool value) {

src/hotspot/share/oops/method.cpp

@@ -36,9 +36,9 @@
 #include "code/debugInfoRec.hpp"
 #include "compiler/compilationPolicy.hpp"
 #include "gc/shared/collectedHeap.inline.hpp"
+#include "interpreter/bytecodes.hpp"
 #include "interpreter/bytecodeStream.hpp"
 #include "interpreter/bytecodeTracer.hpp"
-#include "interpreter/bytecodes.hpp"
 #include "interpreter/interpreter.hpp"
 #include "interpreter/oopMapCache.hpp"
 #include "logging/log.hpp"
@@ -51,8 +51,8 @@
 #include "memory/resourceArea.hpp"
 #include "memory/universe.hpp"
 #include "nmt/memTracker.hpp"
-#include "oops/constMethod.hpp"
 #include "oops/constantPool.hpp"
+#include "oops/constMethod.hpp"
 #include "oops/jmethodIDTable.hpp"
 #include "oops/klass.inline.hpp"
 #include "oops/method.inline.hpp"
@@ -64,8 +64,8 @@
 #include "oops/trainingData.hpp"
 #include "prims/jvmtiExport.hpp"
 #include "prims/methodHandles.hpp"
-#include "runtime/atomic.hpp"
 #include "runtime/arguments.hpp"
+#include "runtime/atomic.hpp"
 #include "runtime/continuationEntry.hpp"
 #include "runtime/frame.inline.hpp"
 #include "runtime/handles.inline.hpp"

src/hotspot/share/oops/method.hpp

@@ -29,8 +29,8 @@
 #include "compiler/compilerDefinitions.hpp"
 #include "oops/annotations.hpp"
 #include "oops/constantPool.hpp"
-#include "oops/methodFlags.hpp"
 #include "oops/instanceKlass.hpp"
+#include "oops/methodFlags.hpp"
 #include "oops/oop.hpp"
 #include "utilities/accessFlags.hpp"
 #include "utilities/align.hpp"

src/hotspot/share/oops/methodCounters.cpp

@@ -26,11 +26,11 @@
 #include "compiler/compiler_globals.hpp"
 #include "compiler/compilerOracle.hpp"
 #include "memory/metaspaceClosure.hpp"
+#include "memory/resourceArea.hpp"
 #include "oops/method.hpp"
 #include "oops/methodCounters.hpp"
 #include "oops/trainingData.hpp"
 #include "runtime/handles.inline.hpp"
-#include "memory/resourceArea.hpp"
 
 MethodCounters::MethodCounters(const methodHandle& mh) :
   _method(mh()),

src/hotspot/share/oops/methodCounters.hpp

@@ -25,9 +25,9 @@
 #ifndef SHARE_OOPS_METHODCOUNTERS_HPP
 #define SHARE_OOPS_METHODCOUNTERS_HPP
 
-#include "oops/metadata.hpp"
 #include "compiler/compilerDefinitions.hpp"
 #include "interpreter/invocationCounter.hpp"
+#include "oops/metadata.hpp"
 #include "utilities/align.hpp"
 
 class MethodTrainingData;

src/hotspot/share/oops/objArrayOop.hpp

@@ -27,6 +27,7 @@
 
 #include "oops/arrayOop.hpp"
 #include "utilities/align.hpp"
+
 #include <type_traits>
 
 class Klass;

src/hotspot/share/oops/oop.hpp

@@ -27,14 +27,15 @@
 
 #include "memory/iterator.hpp"
 #include "memory/memRegion.hpp"
-#include "oops/compressedKlass.hpp"
 #include "oops/accessDecorators.hpp"
+#include "oops/compressedKlass.hpp"
 #include "oops/markWord.hpp"
 #include "oops/metadata.hpp"
 #include "oops/objLayout.hpp"
 #include "runtime/atomic.hpp"
 #include "utilities/globalDefinitions.hpp"
 #include "utilities/macros.hpp"
+
 #include <type_traits>
 
 // oopDesc is the top baseclass for objects classes. The {name}Desc classes describe

src/hotspot/share/oops/oop.inline.hpp

@@ -27,22 +27,22 @@
 
 #include "oops/oop.hpp"
 
-#include "memory/universe.hpp"
 #include "memory/iterator.inline.hpp"
+#include "memory/universe.hpp"
 #include "oops/access.inline.hpp"
 #include "oops/arrayKlass.hpp"
 #include "oops/arrayOop.hpp"
 #include "oops/compressedKlass.inline.hpp"
 #include "oops/instanceKlass.hpp"
-#include "oops/objLayout.inline.hpp"
 #include "oops/markWord.inline.hpp"
+#include "oops/objLayout.inline.hpp"
 #include "oops/oopsHierarchy.hpp"
 #include "runtime/atomic.hpp"
 #include "runtime/globals.hpp"
 #include "utilities/align.hpp"
 #include "utilities/debug.hpp"
-#include "utilities/macros.hpp"
 #include "utilities/globalDefinitions.hpp"
+#include "utilities/macros.hpp"
 
 // Implementation of all inlined member functions defined in oop.hpp
 // We need a separate file to avoid circular references

src/hotspot/share/oops/oopCast.inline.hpp

@@ -24,8 +24,8 @@
 #ifndef SHARE_OOPS_OOPCAST_INLINE_HPP
 #define SHARE_OOPS_OOPCAST_INLINE_HPP
 
-#include "oops/oopsHierarchy.hpp"
 #include "oops/oop.inline.hpp"
+#include "oops/oopsHierarchy.hpp"
 
 template<typename T>
 static bool is_oop_type(oop theOop) {

src/hotspot/share/oops/oopHandle.inline.hpp

@@ -27,8 +27,8 @@
 
 #include "oops/oopHandle.hpp"
 
-#include "oops/access.inline.hpp"
 #include "gc/shared/oopStorage.inline.hpp"
+#include "oops/access.inline.hpp"
 
 inline oop OopHandle::resolve() const {
   if (_obj == nullptr) {

src/hotspot/share/oops/stackChunkOop.inline.hpp

@@ -27,9 +27,9 @@
 
 #include "oops/stackChunkOop.hpp"
 
-#include "gc/shared/collectedHeap.hpp"
 #include "gc/shared/barrierSet.hpp"
 #include "gc/shared/barrierSetStackChunk.hpp"
+#include "gc/shared/collectedHeap.hpp"
 #include "gc/shared/gc_globals.hpp"
 #include "memory/memRegion.hpp"
 #include "memory/universe.hpp"

src/hotspot/share/oops/trainingData.cpp

@@ -22,10 +22,10 @@
  *
  */
 
-#include "ci/ciEnv.hpp"
-#include "ci/ciMetadata.hpp"
 #include "cds/cdsConfig.hpp"
 #include "cds/metaspaceShared.hpp"
+#include "ci/ciEnv.hpp"
+#include "ci/ciMetadata.hpp"
 #include "classfile/classLoaderData.hpp"
 #include "classfile/compactHashtable.hpp"
 #include "classfile/javaClasses.hpp"

src/hotspot/share/oops/trainingData.hpp

@@ -28,8 +28,8 @@
 #include "cds/cdsConfig.hpp"
 #include "classfile/classLoaderData.hpp"
 #include "classfile/compactHashtable.hpp"
-#include "compiler/compilerDefinitions.hpp"
 #include "compiler/compiler_globals.hpp"
+#include "compiler/compilerDefinitions.hpp"
 #include "memory/allocation.hpp"
 #include "memory/metaspaceClosure.hpp"
 #include "oops/instanceKlass.hpp"

src/hotspot/share/oops/typeArrayOop.hpp

@@ -27,6 +27,7 @@
 
 #include "oops/arrayOop.hpp"
 #include "oops/typeArrayKlass.hpp"
+
 #include <type_traits>
 
 // A typeArrayOop is an array containing basic types (non oop elements).

src/hotspot/share/oops/typeArrayOop.inline.hpp

@@ -28,8 +28,8 @@
 #include "oops/typeArrayOop.hpp"
 
 #include "oops/access.inline.hpp"
-#include "oops/oop.inline.hpp"
 #include "oops/arrayOop.hpp"
+#include "oops/oop.inline.hpp"
 
 size_t typeArrayOopDesc::object_size(const TypeArrayKlass* tk) const {
   return object_size(tk->layout_helper(), length());

test/hotspot/jtreg/sources/TestIncludesAreSorted.java

@@ -47,6 +47,7 @@ public class TestIncludesAreSorted {
                     "share/ci",
                     "share/compiler",
                     "share/jvmci",
+                    "share/oops",
                     "share/opto"
     };