infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-03-04 21:20:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

8169344: Potential open file descriptor in exists() of hotspot/agent/src/os/bsd/ps_core.c

Browse Source 
Use access() instead of open() to check for the existence of a file

Reviewed-by: dsamersoff, dholmes
This commit is contained in:
Jini George 2016-11-09 10:56:32 +03:00 committed by Dmitry Samersoff
parent 2c79bd5892
commit 3eedbd0f73
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hotspot/src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2003, 2013, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2003, 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -697,14 +697,8 @@ err:
}
/**local function **/
bool exists(const char *fname)
{
int fd;
if ((fd = open(fname, O_RDONLY)) > 0) {
close(fd);
return true;
}
return false;
bool exists(const char *fname) {
return access(fname, F_OK) == 0;
}
// we check: 1. lib