infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-05-18 01:17:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

6931812: A better implementation of sun.nio.cs.Surrogate.isBMP(int)

Browse Source 
Uc >> 16 == 0 is superior to (int) (char) uc == uc

Reviewed-by: sherman
This commit is contained in:
Ulf Zibis 2010-03-10 14:53:51 -08:00 committed by Martin Buchholz
parent 77c61b9819
commit 3f5bea08cd
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
jdk/src/share/classes/sun/nio/cs/Surrogate.java
View File

@ -78,8 +78,8 @@ public class Surrogate {
* Tells whether or not the given UCS-4 character is in the Basic
* Multilingual Plane, and can be represented using a single char.
*/
public static boolean isBMP(int uc) {
return (int) (char) uc == uc;
public static boolean isBMPCodePoint(int uc) {
return uc >> 16 == 0;
}
/**
@ -290,7 +290,7 @@ public class Surrogate {
* error() will return a descriptive result object
*/
public int generate(int uc, int len, CharBuffer dst) {
if (Surrogate.isBMP(uc)) {
if (Surrogate.isBMPCodePoint(uc)) {
if (Surrogate.is(uc)) {
error = CoderResult.malformedForLength(len);
return -1;
@ -334,7 +334,7 @@ public class Surrogate {
* error() will return a descriptive result object
*/
public int generate(int uc, int len, char[] da, int dp, int dl) {
if (Surrogate.isBMP(uc)) {
if (Surrogate.isBMPCodePoint(uc)) {
if (Surrogate.is(uc)) {
error = CoderResult.malformedForLength(len);
return -1;