infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 12:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

8325030: PhaseMacroExpand::value_from_mem_phi assert with "unknown node on this path"

Browse Source 
Reviewed-by: chagedorn, kvn
This commit is contained in:
Theo Weidmann 2025-01-16 12:16:14 +00:00
parent 24de9dee80
commit 4ad5d5514e
2 changed files with 60 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/hotspot/share/opto/macro.cpp
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2005, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -430,6 +430,10 @@ Node *PhaseMacroExpand::value_from_mem_phi(Node *mem, BasicType ft, const Type *
return nullptr;
}
values.at_put(j, res);
} else if (val->is_top()) {
// This indicates that this path into the phi is dead. Top will eventually also propagate into the Region.
// IGVN will clean this up later.
values.at_put(j, val);
} else {
DEBUG_ONLY( val->dump(); )
assert(false, "unknown node on this path");

55
test/hotspot/jtreg/compiler/macronodes/TestTopInMacroElimination.java Normal file
View File

@ -0,0 +1,55 @@
/*
* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8325030
* @summary Regression test for an assert triggered during allocation elimination because top is found during
* constructing new phis.
* @run main/othervm -XX:-ProfileExceptionHandlers compiler.macronodes.TestTopInMacroElimination
*/
package compiler.macronodes;
public class TestTopInMacroElimination {
public static class A {
int a;
}
public static void main(String[] strArr) {
int i2 = 0;
for (int i = 0; i < 50; ++i) {
try {
synchronized (new A()) {
synchronized (TestTopInMacroElimination.class) {
for (int var19 = 0; var19 < Integer.valueOf(i2);) {
Integer.valueOf(var19);
}
}
}
for (int var8 = 0; var8 < 10000; ++var8) ;
} catch (ArithmeticException a_e) {
}
}
}
}