From 5166094647f8bfae32ef4bbde2e40f68e073b595 Mon Sep 17 00:00:00 2001 From: Severin Gehwolf Date: Wed, 9 Sep 2020 13:53:10 +0000 Subject: [PATCH] 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota The comment is wrong. The 'us' in 'cpu.cfs_quota_us' stands for microseconds, which is read verbatim. Similarly for cgroups v2 all units in 'cpu.max' are in microseconds. Reviewed-by: shade, hseigel --- src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp | 4 ++-- src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp b/src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp index 5fdc2a9abcd..5638213cd60 100644 --- a/src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp +++ b/src/hotspot/os/linux/cgroupV1Subsystem_linux.cpp @@ -203,11 +203,11 @@ char * CgroupV1Subsystem::cpu_cpuset_memory_nodes() { /* cpu_quota * - * Return the number of milliseconds per period + * Return the number of microseconds per period * process is guaranteed to run. * * return: - * quota time in milliseconds + * quota time in microseconds * -1 for no quota * OSCONTAINER_ERROR for not supported */ diff --git a/src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp b/src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp index 1a4708709cc..c51ef9d6dc3 100644 --- a/src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp +++ b/src/hotspot/os/linux/cgroupV2Subsystem_linux.cpp @@ -74,11 +74,11 @@ int CgroupV2Subsystem::cpu_shares() { /* cpu_quota * - * Return the number of milliseconds per period + * Return the number of microseconds per period * process is guaranteed to run. * * return: - * quota time in milliseconds + * quota time in microseconds * -1 for no quota * OSCONTAINER_ERROR for not supported */