infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 12:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

8368089: G1: G1PeriodicGCTask::should_start_periodic_gc may use uninitialised value if os::loadavg is unsupported

Browse Source 
Reviewed-by: ayang, tschatzl, iwalulya
This commit is contained in:
Guanqiang Han 2025-09-25 11:55:18 +00:00 committed by Ivan Walulya
parent 2407eb0522
commit 52e5504627
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/hotspot/share/gc/g1/g1PeriodicGCTask.cpp
View File

@ -54,11 +54,17 @@ bool G1PeriodicGCTask::should_start_periodic_gc(G1CollectedHeap* g1h,
// Check if load is lower than max.
double recent_load;
if ((G1PeriodicGCSystemLoadThreshold > 0.0f) &&
(os::loadavg(&recent_load, 1) == -1 || recent_load > G1PeriodicGCSystemLoadThreshold)) {
log_debug(gc, periodic)("Load %1.2f is higher than threshold %1.2f. Skipping.",
recent_load, G1PeriodicGCSystemLoadThreshold);
return false;
if (G1PeriodicGCSystemLoadThreshold > 0.0) {
if (os::loadavg(&recent_load, 1) == -1) {
G1PeriodicGCSystemLoadThreshold = 0.0;
log_warning(gc, periodic)("System loadavg() call failed, "
"disabling G1PeriodicGCSystemLoadThreshold check.");
// Fall through and start the periodic GC.
} else if (recent_load > G1PeriodicGCSystemLoadThreshold) {
log_debug(gc, periodic)("Load %1.2f is higher than threshold %1.2f. Skipping.",
recent_load, G1PeriodicGCSystemLoadThreshold);
return false;
}
}
// Record counters with GC safepoints blocked, to get a consistent snapshot.