infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-07-31 05:05:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

8214380: AwtDragSource function LoadCache misses a ReleaseLongArrayElements in special case

Browse Source 
Reviewed-by: serb, stuefe
This commit is contained in:
Matthias Baesken 2018-11-30 13:31:31 +01:00
parent 5f2062b484
commit 542ddf4f4d
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/java.desktop/windows/native/libawt/windows/awt_DnDDS.cpp
View File

@ -394,9 +394,12 @@ void AwtDragSource::LoadCache(jlongArray formats) {
return;
}
jboolean isCopy;
jlong *lFormats = env->GetLongArrayElements(formats, &isCopy),
jlong *lFormats = env->GetLongArrayElements(formats, 0),
*saveFormats = lFormats;
if (lFormats == NULL) {
m_ntypes = 0;
return;
}
for (i = 0, m_ntypes = 0; i < items; i++, lFormats++) {
// Warning C4244.
@ -422,6 +425,7 @@ void AwtDragSource::LoadCache(jlongArray formats) {
m_types = (FORMATETC *)safe_Calloc(sizeof(FORMATETC), m_ntypes);
} catch (std::bad_alloc&) {
m_ntypes = 0;
env->ReleaseLongArrayElements(formats, saveFormats, 0);
throw;
}