infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-03-03 12:40:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

8167002: JAXP schema validator: Use HashSet instead of ArrayList for tracking XML IDs

Browse Source 
Reviewed-by: joehw, dfuchs, redestad, lancea
This commit is contained in:
Jonathan Klabunde Tomer 2016-10-03 17:35:11 -07:00 committed by Martin Buchholz
parent 07476b2f7d
commit 5aebe22a1b
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
jaxp/src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/validation/ValidationState.java
View File

@ -52,7 +52,7 @@ public class ValidationState implements ValidationContext {
private SymbolTable fSymbolTable = null;
private Locale fLocale = null;
private ArrayList<String> fIdList;
private HashSet<String> fIds;
private ArrayList<String> fIdRefList;
//
@ -97,7 +97,7 @@ public class ValidationState implements ValidationContext {
String key;
for (int i = 0; i < fIdRefList.size(); i++) {
key = fIdRefList.get(i);
if (fIdList == null || !fIdList.contains(key)) {
if (fIds == null || !fIds.contains(key)) {
if (missingIDs == null) {
missingIDs = new HashSet();
}
@ -112,7 +112,7 @@ public class ValidationState implements ValidationContext {
fExtraChecking = true;
fFacetChecking = true;
fNamespaces = true;
fIdList = null;
fIds = null;
fIdRefList = null;
fEntityState = null;
fNamespaceContext = null;
@ -126,7 +126,7 @@ public class ValidationState implements ValidationContext {
* the two tables.
*/
public void resetIDTables() {
fIdList = null;
fIds = null;
fIdRefList = null;
}
@ -168,12 +168,11 @@ public class ValidationState implements ValidationContext {
// id
public boolean isIdDeclared(String name) {
if (fIdList == null) return false;
return fIdList.contains(name);
return fIds != null && fIds.contains(name);
}
public void addId(String name) {
if (fIdList == null) fIdList = new ArrayList();
fIdList.add(name);
if (fIds == null) fIds = new HashSet<>();
fIds.add(name);
}
// idref