infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 12:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

@ashu-mehra review comment -- make data_addr() function protected

Browse Source
This commit is contained in:
iklam 2026-01-26 10:19:23 -08:00
parent f90910e013
commit 5dd8b69005
2 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/hotspot/share/utilities/growableArray.hpp
View File

@ -116,6 +116,12 @@ protected:
~GrowableArrayView() {}
protected:
// Used by AOTGrowableArray for MetaspaceClosure support.
E** data_addr() {
return &_data;
}
public:
bool operator==(const GrowableArrayView& rhs) const {
if (_len != rhs._len)
@ -297,11 +303,6 @@ public:
}
tty->print("}\n");
}
// MetaspaceClosure support.
E** data_addr() {
return &_data;
}
};
template <typename E>

7
test/hotspot/gtest/utilities/test_metaspaceClosure.cpp
View File

@ -95,6 +95,9 @@ public:
}
return false;
}
int visited_count() {
return _count;
}
};
// iterate an Array<MyMetaData*>
@ -185,7 +188,6 @@ TEST_VM(MetaspaceClosure, GrowableArray_MSOPointer) {
EXPECT_TRUE(closure.has_visited(&x)) << "must be";
EXPECT_TRUE(closure.has_visited(&y)) << "must be";
EXPECT_TRUE(closure.has_visited(&z)) << "must be";
EXPECT_TRUE(closure.has_visited(*array->data_addr())) << "must visit buffer inside GrowableArray";
}
// iterate an AOTGrowableArray<MyMetaData>
@ -214,7 +216,6 @@ TEST_VM(MetaspaceClosure, GrowableArray_MSO) {
EXPECT_TRUE(closure.has_visited(&x)) << "must be";
EXPECT_TRUE(closure.has_visited(&y)) << "must be";
EXPECT_TRUE(closure.has_visited(&z)) << "must be";
EXPECT_TRUE(closure.has_visited(*array->data_addr())) << "must visit buffer inside GrowableArray";
}
// iterate an AOTGrowableArray<jlong>
@ -226,5 +227,5 @@ TEST_VM(MetaspaceClosure, GrowableArray_jlong) {
closure.finish();
EXPECT_TRUE(closure.has_visited(array)) << "must be";
EXPECT_TRUE(closure.has_visited(*array->data_addr())) << "must visit buffer inside GrowableArray";
EXPECT_TRUE(closure.visited_count() == 2) << "must visit buffer inside GrowableArray";
}