infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-02-09 09:58:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

8307067: remove broken EnableThreadSMRExtraValidityChecks option

Browse Source 
Reviewed-by: coleenp, dholmes, sspitsyn, rehn
This commit is contained in:
Daniel D. Daugherty 2023-05-13 14:39:58 +00:00
parent e54051ae9e
commit 5e26e64cbf
3 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hotspot/share/prims/jvmtiExport.cpp
View File

@ -829,8 +829,6 @@ JvmtiExport::cv_external_thread_to_JavaThread(ThreadsList * t_list,
}
// Looks like a live JavaThread at this point.
// We do not check the EnableThreadSMRExtraValidityChecks option
// for this includes() call because JVM/TI's spec is tighter.
if (!t_list->includes(java_thread)) {
// Not on the JavaThreads list so it is not alive.
return JVMTI_ERROR_THREAD_NOT_ALIVE;
@ -872,8 +870,6 @@ JvmtiExport::cv_oop_to_JavaThread(ThreadsList * t_list, oop thread_oop,
}
// Looks like a live JavaThread at this point.
// We do not check the EnableThreadSMRExtraValidityChecks option
// for this includes() call because JVM/TI's spec is tighter.
if (!t_list->includes(java_thread)) {
// Not on the JavaThreads list so it is not alive.
return JVMTI_ERROR_THREAD_NOT_ALIVE;

3
src/hotspot/share/runtime/globals.hpp
View File

@ -953,9 +953,6 @@ const int ObjectAlignmentInBytes = 8;
"null (+offset) will not raise a SIGSEGV, i.e.," \
"ImplicitNullChecks don't work (PPC64).") \
\
product(bool, EnableThreadSMRExtraValidityChecks, true, DIAGNOSTIC, \
"Enable Thread SMR extra validity checks") \
\
product(bool, EnableThreadSMRStatistics, trueInDebug, DIAGNOSTIC, \
"Enable Thread SMR Statistics") \
\

8
src/hotspot/share/runtime/threadSMR.cpp
View File

@ -824,10 +824,10 @@ bool ThreadsListHandle::cv_internal_thread_to_JavaThread(jobject jthread,
// Looks like a live JavaThread at this point.
if (java_thread != JavaThread::current()) {
// jthread is not for the current JavaThread so have to verify
// the JavaThread * against the ThreadsList.
if (EnableThreadSMRExtraValidityChecks && !includes(java_thread)) {
// Not on the JavaThreads list so it is not alive.
// java_thread is not the current JavaThread so we have to verify it
// against the ThreadsList.
if (!includes(java_thread)) {
// Not on this ThreadsList so it is not protected.
return false;
}
}