infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 12:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

6292135: DefaultTableModel.setColumnIdentifiers() Clears JTable Row Heights

Browse Source 
Reviewed-by: tr, kizune
This commit is contained in:
Prasanta Sadhukhan 2025-12-15 04:45:25 +00:00
parent eda1ab2143
commit 5edeb71e3b
2 changed files with 64 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/java.desktop/share/classes/javax/swing/JTable.java
View File

@ -4454,8 +4454,6 @@ public class JTable extends JComponent implements TableModelListener, Scrollable
// The whole thing changed
clearSelectionAndLeadAnchor();
rowModel = null;
if (sortManager != null) {
try {
ignoreSortChange = true;

64
test/jdk/javax/swing/JTable/TestRowHeightWithColIdentifier.java Normal file
View File

@ -0,0 +1,64 @@
/*
* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 6292135
* @summary Verifies DefaultTableModel.setColumnIdentifiers() doesn't
* clear JTable Row Heights
* @run main TestRowHeightWithColIdentifier
*/
import javax.swing.JTable;
import javax.swing.SwingUtilities;
import javax.swing.table.DefaultTableModel;
public class TestRowHeightWithColIdentifier{
public static void main(String[] args) throws Exception {
SwingUtilities.invokeAndWait(() -> {
DefaultTableModel model = new DefaultTableModel(null, new Object[] {"FOO", "BAR"});
JTable table = new JTable(model);
model.addRow(new Object[] {"00", "01"});
model.addRow(new Object[] {"10", "11"});
model.addRow(new Object[] {"20", "21"});
for (int row = 0; row < table.getRowCount(); row++) {
table.setRowHeight(row, 100);
}
for (int row = 0; row < table.getRowCount(); row++) {
System.out.println("Before table rowHeight " + table.getRowHeight(row));
}
int oldRowHeight = table.getRowHeight(0);
model.setColumnIdentifiers(new Object[] {"Check", "it out!"});
for (int row = 0; row < table.getRowCount(); row++) {
System.out.println("After table rowHeight " + table.getRowHeight(row));
}
int curRowHeight = table.getRowHeight(0);
if (curRowHeight != oldRowHeight) {
throw new RuntimeException("DefaultTableModel.setColumnIdentifiers() Clears JTable Row Height");
}
});
}
}