infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 12:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove TimeStamp::No as it's not used. virtual should be flipped to override in bulk (afressed clang warning)

Browse Source
This commit is contained in:
Ivan Bereziuk 2026-01-19 17:08:31 +01:00
parent c86fab4196
commit 5f1cefe074
2 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/hotspot/share/jfr/dcmd/jfrDcmds.hpp
View File

@ -40,10 +40,10 @@ class JfrDCmd : public DCmd {
void print_java_help(const char* help_method) const;
public:
void execute(DCmdSource source, const JcmdOptions& commonOptions, TRAPS) override;
virtual void print_help(const char* name) const;
virtual GrowableArray<const char*>* argument_name_array() const;
virtual GrowableArray<DCmdArgumentInfo*>* argument_info_array() const;
virtual void parse(CmdLine* line, char delim, TRAPS);
void print_help(const char* name) const override;
GrowableArray<const char*>* argument_name_array() const override;
GrowableArray<DCmdArgumentInfo*>* argument_info_array() const override;
void parse(CmdLine* line, char delim, TRAPS) override;
};
class JfrStartFlightRecordingDCmd : public JfrDCmd {
@ -203,7 +203,7 @@ class JfrConfigureFlightRecorderDCmd : public DCmdWithParser {
}
static int num_arguments() { return 10; }
void execute(DCmdSource source, const JcmdOptions& commonOptions, TRAPS) override;
virtual void print_help(const char* name) const;
void print_help(const char* name) const override;
};

15
src/hotspot/share/services/diagnosticFramework.hpp
View File

@ -168,8 +168,7 @@ public:
struct JcmdOptions {
enum class TimeStamp {
Default,
Yes,
No
Yes
};
TimeStamp timestamp;
@ -316,13 +315,13 @@ public:
DCmdWithParser (outputStream *output, bool heap=false) : DCmd(output, heap) { }
static const char* disabled_message() { return "Diagnostic command currently disabled"; }
static const char* impact() { return "Low: No impact"; }
virtual void parse(CmdLine *line, char delim, TRAPS);
void parse(CmdLine *line, char delim, TRAPS) override;
void execute(DCmdSource source, const JcmdOptions& commonOptions, TRAPS) override { }
virtual void reset(TRAPS);
virtual void cleanup();
virtual void print_help(const char* name) const;
virtual GrowableArray<const char*>* argument_name_array() const;
virtual GrowableArray<DCmdArgumentInfo*>* argument_info_array() const;
void reset(TRAPS) override;
void cleanup() override;
void print_help(const char* name) const override;
GrowableArray<const char*>* argument_name_array() const override;
GrowableArray<DCmdArgumentInfo*>* argument_info_array() const override;
DCmdParser* dcmdparser() {
return &_dcmdparser;
}