From 609f2d2cef1d0e9591c1ba79a7dbf39a107b7962 Mon Sep 17 00:00:00 2001 From: Omair Majid Date: Fri, 27 Nov 2009 17:54:45 +0300 Subject: [PATCH] 6832063: OpenJDK fails to open the default ALSA device when PulseAudio is enabled Reviewed-by: amenkov --- .../com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/jdk/src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c b/jdk/src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c index e179ab025cb..fd1102dd421 100644 --- a/jdk/src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c +++ b/jdk/src/solaris/native/com/sun/media/sound/PLATFORM_API_LinuxOS_ALSA_PCM.c @@ -143,8 +143,12 @@ void DAUDIO_GetFormats(INT32 mixerIndex, INT32 deviceID, int isSource, void* cre ERROR1("snd_pcm_hw_params_malloc returned error %d\n", ret); } else { ret = snd_pcm_hw_params_any(handle, hwParams); - if (ret != 0) { - ERROR1("snd_pcm_hw_params_any returned error %d\n", ret); + /* snd_pcm_hw_params_any can return a positive value on success too */ + if (ret < 0) { + ERROR1("snd_pcm_hw_params_any returned error %d\n", ret); + } else { + /* for the logic following this code, set ret to 0 to indicate success */ + ret = 0; } } snd_pcm_hw_params_get_format_mask(hwParams, formatMask);