From 624a4e37eba04015e50a2416e08f4b3c81eb6b40 Mon Sep 17 00:00:00 2001 From: Justin Lu Date: Fri, 23 Jan 2026 15:15:21 -0800 Subject: [PATCH] Resolve undetected BaseTest data providers --- test/jdk/javax/sql/junit/test/rowset/BaseRowSetTests.java | 4 ++-- .../jdk/javax/sql/junit/test/rowset/RowSetMetaDataTests.java | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/test/jdk/javax/sql/junit/test/rowset/BaseRowSetTests.java b/test/jdk/javax/sql/junit/test/rowset/BaseRowSetTests.java index df5a5d75ead..272ea9e7158 100644 --- a/test/jdk/javax/sql/junit/test/rowset/BaseRowSetTests.java +++ b/test/jdk/javax/sql/junit/test/rowset/BaseRowSetTests.java @@ -237,7 +237,7 @@ public class BaseRowSetTests extends CommonRowSetTests { * Validate setNull specifying the supported type values */ @ParameterizedTest - @MethodSource("TODO: cannot automatically find data provider named 'jdbcTypes', please resolve manually.") + @MethodSource("jdbcTypes") public void baseRowSetTest0011(Integer type) throws Exception { brs = new StubBaseRowSet(); brs.setNull(1, type); @@ -249,7 +249,7 @@ public class BaseRowSetTests extends CommonRowSetTests { * typeName is set internally */ @ParameterizedTest - @MethodSource("TODO: cannot automatically find data provider named 'jdbcTypes', please resolve manually.") + @MethodSource("jdbcTypes") public void baseRowSetTest0012(Integer type) throws Exception { brs = new StubBaseRowSet(); brs.setNull(1, type, "SUPERHERO"); diff --git a/test/jdk/javax/sql/junit/test/rowset/RowSetMetaDataTests.java b/test/jdk/javax/sql/junit/test/rowset/RowSetMetaDataTests.java index 395387d925e..8cadb6c1de4 100644 --- a/test/jdk/javax/sql/junit/test/rowset/RowSetMetaDataTests.java +++ b/test/jdk/javax/sql/junit/test/rowset/RowSetMetaDataTests.java @@ -36,6 +36,7 @@ import org.junit.jupiter.api.TestInstance; import org.junit.jupiter.params.ParameterizedTest; import org.junit.jupiter.params.provider.MethodSource; +import org.junit.jupiter.params.provider.ValueSource; import util.BaseTest; @TestInstance(TestInstance.Lifecycle.PER_CLASS) @@ -519,7 +520,7 @@ public class RowSetMetaDataTests extends BaseTest { * Validate that the correct type is returned for the column */ @ParameterizedTest - @MethodSource("TODO: cannot automatically find data provider named 'jdbcTypes', please resolve manually.") + @MethodSource("jdbcTypes") public void test39(Integer type) throws Exception { rsmd.setColumnType(1, type); assertTrue(type == rsmd.getColumnType(1)); @@ -529,7 +530,7 @@ public class RowSetMetaDataTests extends BaseTest { * Validate that the correct value is returned from the isXXX methods */ @ParameterizedTest - @MethodSource("TODO: cannot automatically find data provider named 'trueFalse', please resolve manually.") + @ValueSource(booleans = {true, false}) public void test40(Boolean b) throws Exception { rsmd.setAutoIncrement(1, b); rsmd.setCaseSensitive(1, b);