From 626e2ca2869052b744ddc8326e78925d0a0fa63b Mon Sep 17 00:00:00 2001 From: Semyon Sadetsky Date: Tue, 18 Oct 2016 12:43:07 +0300 Subject: [PATCH] 8166897: Some font overlap in the Optionpane dialog Reviewed-by: azvegint --- .../classes/sun/awt/X11/XDecoratedPeer.java | 9 +-- .../ChangeWindowResizabiltyTest.java | 70 +++++++++++++++++++ 2 files changed, 75 insertions(+), 4 deletions(-) create mode 100644 jdk/test/java/awt/Window/ChangeWindowResizabilty/ChangeWindowResizabiltyTest.java diff --git a/jdk/src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java b/jdk/src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java index 1a8fb48c24a..b708fa56753 100644 --- a/jdk/src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java +++ b/jdk/src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java @@ -301,7 +301,10 @@ abstract class XDecoratedPeer extends XWindowPeer { } private void resetWMSetInsets() { - wm_set_insets = null; + if (XWM.getWMID() != XWM.UNITY_COMPIZ_WM) { + currentInsets = new Insets(0, 0, 0, 0); + wm_set_insets = null; + } } public void handlePropertyNotify(XEvent xev) { @@ -352,7 +355,7 @@ abstract class XDecoratedPeer extends XWindowPeer { // and the initially guessed insets were wrong handleCorrectInsets(in); } - } else if (!dimensions.isClientSizeSet()) { + } else if (!insets_corrected || !dimensions.isClientSizeSet()) { insets_corrected = true; // initial insets were guessed correctly. Re-request // frame bounds because they may be changed by WM if the @@ -908,7 +911,6 @@ abstract class XDecoratedPeer extends XWindowPeer { public void setResizable(boolean resizable) { int fs = winAttr.functions; if (!isResizable() && resizable) { - currentInsets = new Insets(0, 0, 0, 0); resetWMSetInsets(); if (!isEmbedded()) { setReparented(false); @@ -922,7 +924,6 @@ abstract class XDecoratedPeer extends XWindowPeer { winAttr.functions = fs; XWM.setShellResizable(this); } else if (isResizable() && !resizable) { - currentInsets = new Insets(0, 0, 0, 0); resetWMSetInsets(); if (!isEmbedded()) { setReparented(false); diff --git a/jdk/test/java/awt/Window/ChangeWindowResizabilty/ChangeWindowResizabiltyTest.java b/jdk/test/java/awt/Window/ChangeWindowResizabilty/ChangeWindowResizabiltyTest.java new file mode 100644 index 00000000000..441c2738ab5 --- /dev/null +++ b/jdk/test/java/awt/Window/ChangeWindowResizabilty/ChangeWindowResizabiltyTest.java @@ -0,0 +1,70 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* @bug 8166897 + @summary Some font overlap in the Optionpane dialog. + @run main ChangeWindowResizabiltyTest +*/ + +import java.awt.*; + +public class ChangeWindowResizabiltyTest { + public static void main(String[] args) throws Exception { + Robot robot = new Robot(); + for(int i = 0; i < 10; i++) { + Dialog dialog = new Dialog((Frame) null); + Component panel = new Panel(); + panel.setPreferredSize(new Dimension(200, 100)); + dialog.add(panel); + dialog.pack(); + dialog.setVisible(true); + + dialog.setResizable(false); + robot.waitForIdle(); + robot.delay(200); + + System.out.println(panel.getLocationOnScreen()); + System.out.println(dialog.getLocationOnScreen()); + if (panel.getLocationOnScreen().y < + dialog.getLocationOnScreen().y + dialog.getInsets().top) { + dialog.dispose(); + throw new RuntimeException( + "Wrong content position after setResizable(false)"); + } + + dialog.setResizable(true); + robot.waitForIdle(); + robot.delay(200); + System.out.println(panel.getLocationOnScreen()); + System.out.println(dialog.getLocationOnScreen()); + if (panel.getLocationOnScreen().y < + dialog.getLocationOnScreen().y + dialog.getInsets().top) { + dialog.dispose(); + throw new RuntimeException( + "Wrong content position after setResizable(true)"); + } + + dialog.dispose(); + } + } +}