infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-06-07 19:15:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

8259851: Use boolean type for tasks in SubTasksDone

Browse Source 
Reviewed-by: kbarrett, tschatzl
This commit is contained in:
Albert Mingkun Yang 2021-01-21 12:10:37 +00:00 committed by Thomas Schatzl
parent 4bcffeb9f4
commit 6ce0799b66
2 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/hotspot/share/gc/shared/workgroup.cpp
View File

@ -353,7 +353,7 @@ void WorkGangBarrierSync::abort() {
SubTasksDone::SubTasksDone(uint n) :
_tasks(NULL), _n_tasks(n), _threads_completed(0) {
_tasks = NEW_C_HEAP_ARRAY(uint, n, mtInternal);
_tasks = NEW_C_HEAP_ARRAY(bool, n, mtInternal);
clear();
}
@ -363,7 +363,7 @@ bool SubTasksDone::valid() {
void SubTasksDone::clear() {
for (uint i = 0; i < _n_tasks; i++) {
_tasks[i] = 0;
_tasks[i] = false;
}
_threads_completed = 0;
}
@ -374,7 +374,7 @@ void SubTasksDone::all_tasks_completed_impl(uint n_threads,
#ifdef ASSERT
// all non-skipped tasks are claimed
for (uint i = 0; i < _n_tasks; ++i) {
if (_tasks[i] == 0) {
if (!_tasks[i]) {
auto is_skipped = false;
for (size_t j = 0; j < skipped_size; ++j) {
if (i == skipped[j]) {
@ -389,7 +389,7 @@ void SubTasksDone::all_tasks_completed_impl(uint n_threads,
for (size_t i = 0; i < skipped_size; ++i) {
auto task_index = skipped[i];
assert(task_index < _n_tasks, "Array in range.");
assert(_tasks[task_index] == 0, "%d is both claimed and skipped.", task_index);
assert(!_tasks[task_index], "%d is both claimed and skipped.", task_index);
}
#endif
uint observed = _threads_completed;
@ -407,17 +407,11 @@ void SubTasksDone::all_tasks_completed_impl(uint n_threads,
bool SubTasksDone::try_claim_task(uint t) {
assert(t < _n_tasks, "bad task id.");
uint old = _tasks[t];
if (old == 0) {
old = Atomic::cmpxchg(&_tasks[t], 0u, 1u);
}
bool res = old == 0;
return res;
return !_tasks[t] && !Atomic::cmpxchg(&_tasks[t], false, true);
}
SubTasksDone::~SubTasksDone() {
FREE_C_HEAP_ARRAY(uint, _tasks);
FREE_C_HEAP_ARRAY(bool, _tasks);
}
// *** SequentialSubTasksDone

2
src/hotspot/share/gc/shared/workgroup.hpp
View File

@ -302,7 +302,7 @@ public:
// enumeration type.
class SubTasksDone: public CHeapObj<mtInternal> {
volatile uint* _tasks;
volatile bool* _tasks;
uint _n_tasks;
volatile uint _threads_completed;