infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-03-23 06:10:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

8266028: C2 computes -0.0 for Math.pow(-0.0, 0.5)

Browse Source 
Reviewed-by: aph, neliasso, kvn
This commit is contained in:
Jie Fu 2021-04-28 06:16:47 +00:00
parent ca37be1ead
commit 75a2354dc2
2 changed files with 10 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hotspot/share/opto/library_call.cpp
View File

@ -1654,7 +1654,7 @@ bool LibraryCallKit::inline_math_pow() {
Node* phi = new PhiNode(region, Type::DOUBLE);
Node* cmp = _gvn.transform(new CmpDNode(base, zero));
Node* test = _gvn.transform(new BoolNode(cmp, BoolTest::lt));
Node* test = _gvn.transform(new BoolNode(cmp, BoolTest::le));
Node* if_pow = generate_slow_guard(test, NULL);
Node* value_sqrt = _gvn.transform(new SqrtDNode(C, control(), base));

20
test/hotspot/jtreg/compiler/intrinsics/math/TestPow0Dot5Opt.java
View File

@ -43,17 +43,6 @@ public class TestPow0Dot5Opt {
if (r1 != r2) {
throw new RuntimeException("pow(" + a + ", 0.5), expected: " + r1 + ", actual: " + r2);
}
}
public static void main(String[] args) throws Exception {
for (int i = 0; i < 10; i++) {
for (int j = 1; j < 100000; j++) {
test(j * 1.0);
test(1.0 / j);
}
}
test(0.0);
// Special case: pow(+0.0, 0.5) = 0.0
double r = Math.pow(+0.0, 0.5);
@ -86,4 +75,13 @@ public class TestPow0Dot5Opt {
}
}
public static void main(String[] args) throws Exception {
for (int i = 0; i < 10; i++) {
for (int j = 1; j < 100000; j++) {
test(j * 1.0);
test(1.0 / j);
}
}
}
}