From 77ee7f0e2494f01cf55c2b11152c2f0d98d80280 Mon Sep 17 00:00:00 2001 From: Albert Mingkun Yang Date: Wed, 7 Feb 2024 12:21:21 +0000 Subject: [PATCH] 8325221: Obsolete TLABStats Reviewed-by: tschatzl, kbarrett --- src/hotspot/share/gc/shared/tlab_globals.hpp | 3 --- src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp | 1 - src/hotspot/share/runtime/arguments.cpp | 2 +- .../hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java | 1 - 4 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/hotspot/share/gc/shared/tlab_globals.hpp b/src/hotspot/share/gc/shared/tlab_globals.hpp index 0b047b4b9e8..0c135d490ec 100644 --- a/src/hotspot/share/gc/shared/tlab_globals.hpp +++ b/src/hotspot/share/gc/shared/tlab_globals.hpp @@ -46,9 +46,6 @@ product(bool, ZeroTLAB, false, \ "Zero out the newly created TLAB") \ \ - product(bool, TLABStats, true, \ - "Provide more detailed and expensive TLAB statistics.") \ - \ product(size_t, MinTLABSize, 2*K, \ "Minimum allowed TLAB size (in bytes)") \ range(1, max_uintx/2) \ diff --git a/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp b/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp index 89fa78b10f3..8822aed0cbe 100644 --- a/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp +++ b/src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp @@ -310,7 +310,6 @@ JVMCIObjectArray CompilerToVM::initialize_intrinsics(JVMCI_TRAPS) { do_bool_flag(RestrictContended) \ do_intx_flag(StackReservedPages) \ do_intx_flag(StackShadowPages) \ - do_bool_flag(TLABStats) \ do_uintx_flag(TLABWasteIncrement) \ do_intx_flag(TypeProfileWidth) \ do_bool_flag(UseAESIntrinsics) \ diff --git a/src/hotspot/share/runtime/arguments.cpp b/src/hotspot/share/runtime/arguments.cpp index 78c26ae57f5..8a4b54a2258 100644 --- a/src/hotspot/share/runtime/arguments.cpp +++ b/src/hotspot/share/runtime/arguments.cpp @@ -504,7 +504,6 @@ static SpecialFlag const special_jvm_flags[] = { // --- Deprecated alias flags (see also aliased_jvm_flags) - sorted by obsolete_in then expired_in: { "CreateMinidumpOnCrash", JDK_Version::jdk(9), JDK_Version::undefined(), JDK_Version::undefined() }, - { "TLABStats", JDK_Version::jdk(12), JDK_Version::undefined(), JDK_Version::undefined() }, // -------------- Obsolete Flags - sorted by expired_in -------------- @@ -526,6 +525,7 @@ static SpecialFlag const special_jvm_flags[] = { { "MinRAMFraction", JDK_Version::jdk(10), JDK_Version::jdk(23), JDK_Version::jdk(24) }, { "InitialRAMFraction", JDK_Version::jdk(10), JDK_Version::jdk(23), JDK_Version::jdk(24) }, { "DefaultMaxRAMFraction", JDK_Version::jdk(8), JDK_Version::jdk(23), JDK_Version::jdk(24) }, + { "TLABStats", JDK_Version::jdk(12), JDK_Version::jdk(23), JDK_Version::jdk(24) }, #ifdef ASSERT { "DummyObsoleteTestFlag", JDK_Version::undefined(), JDK_Version::jdk(18), JDK_Version::undefined() }, #endif diff --git a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java index 49399ca2135..3bb6a4b9d6b 100644 --- a/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java +++ b/test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java @@ -56,7 +56,6 @@ public class VMDeprecatedOptions { ArrayList deprecated = new ArrayList( Arrays.asList(new String[][] { // deprecated non-alias flags: - {"TLABStats", "false"}, {"AllowRedefinitionToAddDeleteMethods", "true"}, // deprecated alias flags (see also aliased_jvm_flags):