infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 12:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

8232933: Javac inferred type does not conform to equality constraint

Browse Source 
Reviewed-by: mcimadamore
This commit is contained in:
Vicente Romero 2022-11-03 12:08:23 +00:00
parent 6ee8ccfcfe
commit 7a85441a85
2 changed files with 60 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/jdk.compiler/share/classes/com/sun/tools/javac/comp/InferenceContext.java
View File

@ -337,6 +337,17 @@ public class InferenceContext {
if (roots.length() == inferencevars.length()) {
return this;
}
/* if any of the inference vars is a captured variable bail out, this is because
* we could end up generating more than necessary captured variables in an outer
* inference context and then when we need to propagate back to an inner inference
* context that has been minimized it could be that some bounds constraints doesn't
* hold like subtyping constraints between bonds etc.
*/
for (Type iv : inferencevars) {
if (iv.hasTag(TypeTag.TYPEVAR) && ((TypeVar)iv).isCaptured()) {
return this;
}
}
ReachabilityVisitor rv = new ReachabilityVisitor();
rv.scan(roots);
if (rv.min.size() == inferencevars.length()) {

49
test/langtools/tools/javac/inference_context_min/DontMinimizeInfContextTest.java Normal file
View File

@ -0,0 +1,49 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8232933
* @summary Javac inferred type does not conform to equality constraint
* @compile DontMinimizeInfContextTest.java
*/
import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.stream.Collectors;
class DontMinimizeInfContextTest {
void m() {
List<? extends A<?, ?>> a = new LinkedList<>();
Map<String, List<A<?, ?>>> b = a.stream().collect(
Collectors.groupingBy(A::getval, Collectors.toList())
);
}
class A<K, V> {
String getval() {
return "s";
}
}
}