From 7b43f3402c08daf48e69036c0d9a9e127b4fc8a8 Mon Sep 17 00:00:00 2001 From: Zhengyu Gu Date: Thu, 21 Feb 2013 07:50:48 -0500 Subject: [PATCH] 8008071: Crashed in promote_malloc_records() with Kitchensink after 19 days Added NULL pointer check for arena size record Reviewed-by: sspitsyn, dholmes --- hotspot/src/share/vm/services/memSnapshot.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hotspot/src/share/vm/services/memSnapshot.cpp b/hotspot/src/share/vm/services/memSnapshot.cpp index dbc0bbb4f18..1a204e7f05b 100644 --- a/hotspot/src/share/vm/services/memSnapshot.cpp +++ b/hotspot/src/share/vm/services/memSnapshot.cpp @@ -528,7 +528,8 @@ bool MemSnapshot::promote_malloc_records(MemPointerArrayIterator* itr) { // an arena record can be followed by a size record, we need to remove both if (matched_rec->is_arena_record()) { MemPointerRecord* next = (MemPointerRecord*)malloc_snapshot_itr.peek_next(); - if (next->is_arena_memory_record() && next->is_memory_record_of_arena(matched_rec)) { + if (next != NULL && next->is_arena_memory_record() && + next->is_memory_record_of_arena(matched_rec)) { malloc_snapshot_itr.remove(); } }