infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-02-11 19:08:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

8301170: perfMemory_windows.cpp add free_security_attr to early returns

Browse Source 
Reviewed-by: stuefe, dholmes
This commit is contained in:
Matthias Baesken 2023-01-31 08:20:52 +00:00
parent 33e653e284
commit 810c8a271b
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/hotspot/os/windows/perfMemory_windows.cpp
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2001, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2001, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -1240,6 +1240,7 @@ static bool make_user_tmp_dir(const char* dirname) {
if (PrintMiscellaneous && Verbose) {
warning("%s directory is insecure\n", dirname);
}
free_security_attr(pDirSA);
return false;
}
// The administrator should be able to delete this directory.
@ -1255,18 +1256,15 @@ static bool make_user_tmp_dir(const char* dirname) {
dirname, lasterror);
}
}
}
else {
} else {
if (PrintMiscellaneous && Verbose) {
warning("CreateDirectory failed: %d\n", GetLastError());
}
free_security_attr(pDirSA);
return false;
}
}
// free the security attributes structure
free_security_attr(pDirSA);
return true;
}
@ -1298,6 +1296,8 @@ static HANDLE create_sharedmem_resources(const char* dirname, const char* filena
if (!make_user_tmp_dir(dirname)) {
// could not make/find the directory or the found directory
// was not secure
free_security_attr(lpFileSA);
free_security_attr(lpSmoSA);
return NULL;
}
@ -1329,6 +1329,7 @@ static HANDLE create_sharedmem_resources(const char* dirname, const char* filena
if (PrintMiscellaneous && Verbose) {
warning("could not create file %s: %d\n", filename, lasterror);
}
free_security_attr(lpSmoSA);
return NULL;
}