From 859ca75b4c269bc71d1e9638b5b02bbb6386166d Mon Sep 17 00:00:00 2001 From: Thomas Schatzl Date: Tue, 24 Jan 2023 17:15:53 +0000 Subject: [PATCH] 8300862: Remove some G1 collection set remembered set debugging code Reviewed-by: ayang, iwalulya --- src/hotspot/share/gc/g1/g1CollectedHeap.cpp | 49 --------------------- src/hotspot/share/gc/g1/g1CollectedHeap.hpp | 4 -- 2 files changed, 53 deletions(-) diff --git a/src/hotspot/share/gc/g1/g1CollectedHeap.cpp b/src/hotspot/share/gc/g1/g1CollectedHeap.cpp index 202a192eeef..94d29b12bd3 100644 --- a/src/hotspot/share/gc/g1/g1CollectedHeap.cpp +++ b/src/hotspot/share/gc/g1/g1CollectedHeap.cpp @@ -2486,55 +2486,6 @@ void G1CollectedHeap::print_tracing_info() const { concurrent_mark()->print_summary_info(); } -#ifndef PRODUCT -// Helpful for debugging RSet issues. - -class PrintRSetsClosure : public HeapRegionClosure { -private: - const char* _msg; - size_t _occupied_sum; - -public: - bool do_heap_region(HeapRegion* r) { - HeapRegionRemSet* hrrs = r->rem_set(); - size_t occupied = hrrs->occupied(); - _occupied_sum += occupied; - - tty->print_cr("Printing RSet for region " HR_FORMAT, HR_FORMAT_PARAMS(r)); - if (occupied == 0) { - tty->print_cr(" RSet is empty"); - } else { - tty->print_cr("hrrs " PTR_FORMAT, p2i(hrrs)); - } - tty->print_cr("----------"); - return false; - } - - PrintRSetsClosure(const char* msg) : _msg(msg), _occupied_sum(0) { - tty->cr(); - tty->print_cr("========================================"); - tty->print_cr("%s", msg); - tty->cr(); - } - - ~PrintRSetsClosure() { - tty->print_cr("Occupied Sum: " SIZE_FORMAT, _occupied_sum); - tty->print_cr("========================================"); - tty->cr(); - } -}; - -void G1CollectedHeap::print_cset_rsets() { - PrintRSetsClosure cl("Printing CSet RSets"); - collection_set_iterate_all(&cl); -} - -void G1CollectedHeap::print_all_rsets() { - PrintRSetsClosure cl("Printing All RSets");; - heap_region_iterate(&cl); -} -#endif // PRODUCT - bool G1CollectedHeap::print_location(outputStream* st, void* addr) const { return BlockLocationPrinter::print_location(st, addr); } diff --git a/src/hotspot/share/gc/g1/g1CollectedHeap.hpp b/src/hotspot/share/gc/g1/g1CollectedHeap.hpp index 8652f80d5ea..7f6d8fe8254 100644 --- a/src/hotspot/share/gc/g1/g1CollectedHeap.hpp +++ b/src/hotspot/share/gc/g1/g1CollectedHeap.hpp @@ -1330,10 +1330,6 @@ public: // Override void print_tracing_info() const override; - // The following two methods are helpful for debugging RSet issues. - void print_cset_rsets() PRODUCT_RETURN; - void print_all_rsets() PRODUCT_RETURN; - // Used to print information about locations in the hs_err file. bool print_location(outputStream* st, void* addr) const override; };