From 85ca0813f1624141993b20b3d8e404f86da2cef3 Mon Sep 17 00:00:00 2001 From: Harshitha Onkar Date: Fri, 23 May 2025 17:59:47 +0000 Subject: [PATCH] 8354316: clang/linux build fails with -Wunused-result warning at XToolkit.c:695:9 Reviewed-by: aivanov, ihse, serb, kizune, syan, erikj --- make/modules/java.desktop/lib/AwtLibraries.gmk | 1 - src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c | 6 ++++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/make/modules/java.desktop/lib/AwtLibraries.gmk b/make/modules/java.desktop/lib/AwtLibraries.gmk index 5414c93c908..463e09e12dc 100644 --- a/make/modules/java.desktop/lib/AwtLibraries.gmk +++ b/make/modules/java.desktop/lib/AwtLibraries.gmk @@ -278,7 +278,6 @@ ifeq ($(call isTargetOs, windows macosx)+$(ENABLE_HEADLESS_ONLY), false+false) DISABLED_WARNINGS_gcc_X11TextRenderer_md.c := unused-but-set-variable, \ DISABLED_WARNINGS_gcc_XlibWrapper.c := type-limits pointer-to-int-cast, \ DISABLED_WARNINGS_gcc_XRBackendNative.c := maybe-uninitialized, \ - DISABLED_WARNINGS_gcc_XToolkit.c := unused-result, \ DISABLED_WARNINGS_gcc_XWindow.c := unused-function, \ DISABLED_WARNINGS_clang_awt_Taskbar.c := parentheses, \ DISABLED_WARNINGS_clang_gtk3_interface.c := unused-function parentheses, \ diff --git a/src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c b/src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c index abe3a1c54ce..d5f3130386d 100644 --- a/src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c +++ b/src/java.desktop/unix/native/libawt_xawt/xawt/XToolkit.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2002, 2023, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2002, 2025, Oracle and/or its affiliates. All rights reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it @@ -692,7 +692,9 @@ void awt_output_flush() { static void wakeUp() { static char wakeUp_char = 'p'; if (!isMainThread() && awt_pipe_inited) { - write ( AWT_WRITEPIPE, &wakeUp_char, 1 ); + if (write(AWT_WRITEPIPE, &wakeUp_char, 1) < 0) { + DTRACE_PRINTLN("wakeUp(): write to AWT pipe failed"); + } } }