infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 03:58:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

8298321: 2 File Leak defect groups in 2 files

Browse Source 
Reviewed-by: vlivanov, iklam, dholmes
This commit is contained in:
Calvin Cheung 2023-01-11 17:48:36 +00:00
parent d663b5da10
commit 9c1e98dac5
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/hotspot/os/posix/perfMemory_posix.cpp
View File

@ -1205,7 +1205,10 @@ static void mmap_attach_shared(int vmid, char** addr, size_t* sizep, TRAPS) {
FREE_C_HEAP_ARRAY(char, dirname);
FREE_C_HEAP_ARRAY(char, filename);
if (fd == OS_ERR || HAS_PENDING_EXCEPTION) {
if (HAS_PENDING_EXCEPTION) {
assert(fd == OS_ERR, "open_sharedmem_file always return OS_ERR on exceptions");
}
if (fd == OS_ERR) {
return;
}

3
src/hotspot/share/compiler/directivesParser.cpp
View File

@ -96,10 +96,9 @@ bool DirectivesParser::parse_from_file_inner(const char* filename, outputStream*
// read contents into resource array
char* buffer = NEW_RESOURCE_ARRAY(char, st.st_size+1);
ssize_t num_read = ::read(file_handle, (char*) buffer, st.st_size);
::close(file_handle);
if (num_read >= 0) {
buffer[num_read] = '\0';
// close file
::close(file_handle);
return parse_string(buffer, stream) > 0;
}
}