8354341: Open some JTable bugs 7

Reviewed-by: kizune, serb
This commit is contained in:
Alisen Chung 2025-04-22 08:58:42 +00:00
parent 7cd084cf35
commit 9eeb86d972
4 changed files with 448 additions and 0 deletions

View File

@ -0,0 +1,187 @@
/*
* Copyright (c) 1999, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import java.awt.Color;
import java.awt.Dimension;
import javax.swing.DefaultCellEditor;
import javax.swing.JComboBox;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.border.BevelBorder;
import javax.swing.table.AbstractTableModel;
import javax.swing.table.DefaultTableCellRenderer;
import javax.swing.table.TableCellRenderer;
import javax.swing.table.TableColumn;
import javax.swing.table.TableModel;
/*
* @test
* @bug 4201917
* @summary Shift Click in table before making selection
* @library /java/awt/regtesthelpers
* @build PassFailJFrame
* @run main/manual ShiftClick
*/
public class ShiftClick {
private static final String INSTRUCTIONS = """
Shift click in the table. Check that all cells
from the first through where you clicked are selected.
If the cells are selected, press pass, otherwise fail.
""";
public static void main(String[] args) throws Exception {
PassFailJFrame.builder()
.instructions(INSTRUCTIONS)
.columns(50)
.testUI(ShiftClick::createTestUI)
.logArea(6)
.build()
.awaitAndCheck();
}
public static JFrame createTestUI() {
JFrame frame = new JFrame("ShiftClick");
// Take the dummy data from SwingSet.
final String[] names = {"First Name", "Last Name", "Favorite Color",
"Favorite Number", "Vegetarian"};
final Object[][] data = {
{"Mark", "Andrews", "Red", 2, true},
{"Tom", "Ball", "Blue", 99, false},
{"Alan", "Chung", "Green", 838, false},
{"Jeff", "Dinkins", "Turquois", 8, true},
{"Amy", "Fowler", "Yellow", 3, false},
{"Brian", "Gerhold", "Green", 0, false},
{"James", "Gosling", "Pink", 21, false},
{"David", "Karlton", "Red", 1, false},
{"Dave", "Kloba", "Yellow", 14, false},
{"Peter", "Korn", "Purple", 12, false},
{"Phil", "Milne", "Purple", 3, false},
{"Dave", "Moore", "Green", 88, false},
{"Hans", "Muller", "Maroon", 5, false},
{"Rick", "Levenson", "Blue", 2, false},
{"Tim", "Prinzing", "Blue", 22, false},
{"Chester", "Rose", "Black", 0, false},
{"Ray", "Ryan", "Gray", 77, false},
{"Georges", "Saab", "Red", 4, false},
{"Willie", "Walker", "Phthalo Blue", 4, false},
{"Kathy", "Walrath", "Blue", 8, false},
{"Arnaud", "Weber", "Green", 44, false}
};
// Create a model of the data.
TableModel dataModel = new AbstractTableModel() {
// These methods always need to be implemented.
public int getColumnCount() {
return names.length;
}
public int getRowCount() {
return data.length;
}
public Object getValueAt(int row, int col) {
return data[row][col];
}
// The default implementations of these methods in
// AbstractTableModel would work, but we can refine them.
public String getColumnName(int column) {
return names[column];
}
public Class getColumnClass(int c) {
return getValueAt(0, c).getClass();
}
public boolean isCellEditable(int row, int col) {
return true;
}
public void setValueAt(Object aValue, int row, int column) {
System.out.println("Setting value to: " + aValue);
data[row][column] = aValue;
}
};
// Create the table
JTable tableView = new JTable(dataModel);
// Turn off auto-resizing so that we can set column sizes programmatically.
// In this mode, all columns will get their preferred widths, as set blow.
tableView.setAutoResizeMode(JTable.AUTO_RESIZE_OFF);
// Create a combo box to show that you can use one in a table.
JComboBox comboBox = new JComboBox();
comboBox.addItem("Red");
comboBox.addItem("Orange");
comboBox.addItem("Yellow");
comboBox.addItem("Green");
comboBox.addItem("Blue");
comboBox.addItem("Indigo");
comboBox.addItem("Violet");
TableColumn colorColumn = tableView.getColumn("Favorite Color");
// Use the combo box as the editor in the "Favorite Color" column.
colorColumn.setCellEditor(new DefaultCellEditor(comboBox));
// Set a pink background and tooltip for the Color column renderer.
DefaultTableCellRenderer colorColumnRenderer = new DefaultTableCellRenderer();
colorColumnRenderer.setBackground(Color.pink);
colorColumnRenderer.setToolTipText("Click for combo box");
colorColumn.setCellRenderer(colorColumnRenderer);
// Set a tooltip for the header of the colors column.
TableCellRenderer headerRenderer = colorColumn.getHeaderRenderer();
if (headerRenderer instanceof DefaultTableCellRenderer)
((DefaultTableCellRenderer) headerRenderer).setToolTipText("Hi Mom!");
// Set the width of the "Vegetarian" column.
TableColumn vegetarianColumn = tableView.getColumn("Vegetarian");
vegetarianColumn.setPreferredWidth(100);
// Show the values in the "Favorite Number" column in different colors.
TableColumn numbersColumn = tableView.getColumn("Favorite Number");
DefaultTableCellRenderer numberColumnRenderer = new DefaultTableCellRenderer() {
public void setValue(Object value) {
int cellValue = (value instanceof Number) ? ((Number) value).intValue() : 0;
setForeground((cellValue > 30) ? Color.black : Color.red);
setText((value == null) ? "" : value.toString());
}
};
numberColumnRenderer.setHorizontalAlignment(JLabel.RIGHT);
numbersColumn.setCellRenderer(numberColumnRenderer);
numbersColumn.setPreferredWidth(110);
// Finish setting up the table.
JScrollPane scrollpane = new JScrollPane(tableView);
scrollpane.setBorder(new BevelBorder(BevelBorder.LOWERED));
scrollpane.setPreferredSize(new Dimension(430, 200));
frame.add(scrollpane);
frame.setSize(500, 200);
return frame;
}
}

View File

@ -0,0 +1,84 @@
/*
* Copyright (c) 1998, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import javax.swing.JFrame;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.table.AbstractTableModel;
import javax.swing.table.TableModel;
/*
* @test
* @bug 4128506
* @summary Tests that JTable with AUTO_RESIZE_ALL_COLUMNS correctly compute width of columns
* @library /java/awt/regtesthelpers
* @build PassFailJFrame
* @run main/manual bug4128506
*/
public class bug4128506 {
private static final String INSTRUCTIONS = """
If the columns of JTable have the same width the test passes, else test fails.
""";
public static void main(String[] args) throws Exception {
PassFailJFrame.builder()
.instructions(INSTRUCTIONS)
.columns(50)
.testUI(bug4128506::createTestUI)
.build()
.awaitAndCheck();
}
public static JFrame createTestUI() {
final Object[][] data = {
{"cell_1_1", "cell_1_2", "cell_1_3"},
{"cell_2_1", "cell_2_2", "cell_2_3"},
{"cell_3_1", "cell_3_2", "cell_3_3"},
{"cell_4_1", "cell_4_2", "cell_4_3"},
};
TableModel dataModel = new AbstractTableModel() {
public int getColumnCount() {
return 3;
}
public int getRowCount() {
return data.length;
}
public Object getValueAt(int row, int col) {
return data[row][col];
}
};
JFrame frame = new JFrame("bug4128506");
JTable tableView = new JTable(dataModel);
tableView.setAutoResizeMode(JTable.AUTO_RESIZE_ALL_COLUMNS);
tableView.getColumnModel().getColumn(1).setMinWidth(5);
JScrollPane scrollpane = new JScrollPane(tableView);
frame.add(scrollpane);
frame.pack();
return frame;
}
}

View File

@ -0,0 +1,103 @@
/*
* Copyright (c) 1998, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import java.awt.Dimension;
import java.awt.Robot;
import java.util.Vector;
import javax.swing.JFrame;
import javax.swing.JPanel;
import javax.swing.JScrollPane;
import javax.swing.JTable;
import javax.swing.SwingUtilities;
import javax.swing.table.DefaultTableModel;
/*
* @test
* @bug 4190222
* @summary Setting data vector on the model correctly repaint table
* @key headful
* @run main bug4190222
*/
public class bug4190222 {
static JFrame frame;
static DefaultTableModel dtm;
static JTable tbl;
static Vector data;
static Vector colNames;
public static void main(String[] args) throws Exception {
try {
Robot robot = new Robot();
robot.setAutoDelay(250);
SwingUtilities.invokeAndWait(() -> createTestUI());
robot.waitForIdle();
robot.delay(1000);
SwingUtilities.invokeAndWait(() -> {
Dimension preResize = tbl.getSize();
dtm.setDataVector(data, colNames);
if (!preResize.equals(tbl.getSize())) {
throw new RuntimeException("Size of table changed after resizing.");
}
});
} finally {
SwingUtilities.invokeAndWait(() -> {
if (frame != null) {
frame.dispose();
}
});
}
}
public static void createTestUI() {
frame = new JFrame("bug4190222");
data = new Vector(1, 1);
colNames = new Vector(3);
for (int i = 1; i < 4; i++) {
Vector row = new Vector(1, 1);
row.addElement("Row " + i + ", Col 1");
row.addElement("Row " + i + ", Col 2");
row.addElement("Row " + i + ", Col 3");
data.addElement(row);
}
colNames.addElement("Col 1");
colNames.addElement("Col 2");
colNames.addElement("Col 3");
dtm = new DefaultTableModel(data, colNames);
tbl = new JTable(dtm);
JScrollPane scrollPane = new JScrollPane(tbl);
frame.add("Center", scrollPane);
JPanel panel = new JPanel();
frame.add("South", panel);
frame.pack();
frame.setLocationRelativeTo(null);
frame.setVisible(true);
}
}

View File

@ -0,0 +1,74 @@
/*
* Copyright (c) 1999, 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import java.awt.BorderLayout;
import java.awt.Dimension;
import javax.swing.JFrame;
import javax.swing.JScrollPane;
import javax.swing.JTable;
/*
* @test
* @bug 4224179
* @summary Tests if Table default cell editor doesn't handle % (percent) character correctly
* @library /java/awt/regtesthelpers
* @build PassFailJFrame
* @run main/manual bug4224179
*/
public class bug4224179 {
private static final String INSTRUCTIONS = """
1. Click ONCE on the center cell ("Huml")
2. Type the following symbols one after another: a%b
If the center cell doesn't read "Humla%b" the test fails.
3. After the above, press the ESCAPE key and note that the cell
reverts back to "Huml"
4. Do the stuff in part 1 again
5. Press the ESCAPE key
If the center cell now reads "Huml" as it initially was,
the test passed and fails otherwise.
""";
public static void main(String[] args) throws Exception {
PassFailJFrame.builder()
.instructions(INSTRUCTIONS)
.columns(50)
.testUI(bug4224179::createTestUI)
.build()
.awaitAndCheck();
}
public static JFrame createTestUI() {
JFrame frame = new JFrame("bug4224179");
JTable table = new JTable(3, 3);
table.setValueAt("Huml", 1, 1);
table.setPreferredScrollableViewportSize(new Dimension(500, 70));
JScrollPane scrollPane = new JScrollPane(table);
frame.add(scrollPane, BorderLayout.CENTER);
frame.pack();
return frame;
}
}