infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-03-18 11:53:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

8229421: The logic of java/net/ipv6tests/TcpTest.java is flawed

Browse Source 
The test is fixed to ignore rogue client connection. However it remains succeptible to intermittent failures due to the use of the wildcad address.

Reviewed-by: dfuchs
This commit is contained in:
Patrick Concannon 2019-08-20 11:15:23 +01:00 committed by Daniel Fuchs
parent 047b8bfeb7
commit 9f41d4d2f2
1 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
test/jdk/java/net/ipv6tests/TcpTest.java
View File

@ -133,7 +133,19 @@ public class TcpTest extends Tests {
dprintln ("connecting to " + ia6addr);
c2 = new Socket ();
c2.connect (sadr6, 1000);
throw new RuntimeException ("connect to IPv6 address should be refused");
dprintln ("Unexpected successful connection: " + c2);
// Connect should fail with timeout exception. However, if something else is
// accepting connections, verify it is not our server.
server.setSoTimeout(500);
// Ok if accept() fails because of timeout
while (true) {
// acceptedSocket could be connected to c1, but not c2
try (Socket acceptedSocket = server.accept()) {
dprintln("accepted socket: " + acceptedSocket);
if (acceptedSocket.getRemoteSocketAddress().equals(c2.getLocalSocketAddress()))
throw new RuntimeException("connect to IPv6 address should be refused");
}
}
} catch (IOException e) { }
server.close ();
c1.close ();
@ -153,7 +165,19 @@ public class TcpTest extends Tests {
try {
dprintln ("connecting to " + ia4addr);
c2 = new Socket (ia4addr, port);
throw new RuntimeException ("connect to IPv4 address should be refused");
dprintln ("Unexpected successful connection: " + c2);
// Connect should fail with timeout exception. However, if something else is
// accepting connections, verify it is not our server.
server.setSoTimeout(500);
// Ok if accept() fails because of timeout
while (true) {
// acceptedSocket could be connected to c1, but not c2
try (Socket acceptedSocket = server.accept()) {
dprintln("accepted socket: " + acceptedSocket);
if (acceptedSocket.getRemoteSocketAddress().equals(c2.getLocalSocketAddress()))
throw new RuntimeException("connect to IPv4 address should be refused");
}
}
} catch (IOException e) { }
server.close ();
c1.close ();