8265433: IGV: add graph tooltips with properties

Reviewed-by: rcastanedalo, tholenstein
This commit is contained in:
Koichi Sakata 2022-08-09 08:18:44 +00:00 committed by Roberto Castañeda Lozano
parent 77398430b5
commit af243ca334
3 changed files with 52 additions and 1 deletions

View File

@ -0,0 +1,48 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation. Oracle designates this
* particular file as subject to the "Classpath" exception as provided
* by Oracle in the LICENSE file that accompanied this code.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
package com.sun.hotspot.igv.util;
import com.sun.hotspot.igv.data.Properties;
import com.sun.hotspot.igv.data.Property;
import com.sun.hotspot.igv.util.StringUtils;
/**
*
* @author ksakata
*/
public class PropertiesConverter {
public static String convertToHTML(final Properties properties) {
StringBuilder sb = new StringBuilder("<html><body><table cellpadding=\"0\" cellspacing=\"0\">");
for (Property p : properties) {
sb.append("<tr><td>")
.append(StringUtils.escapeHTML(p.getName()))
.append("</td><td width=\"10\"></td><td>")
.append(StringUtils.escapeHTML(p.getValue()))
.append("</td></tr>");
}
sb.append("</table></body></html>");
return sb.toString();
}
}

View File

@ -58,7 +58,7 @@ public class StringUtils {
str.append("&quot;");
break;
case '\'':
str.append("&apos;");
str.append("&#39;");
break;
default:
assert false;

View File

@ -29,6 +29,7 @@ import com.sun.hotspot.igv.data.services.GraphViewer;
import com.sun.hotspot.igv.graph.Figure;
import com.sun.hotspot.igv.util.DoubleClickAction;
import com.sun.hotspot.igv.util.DoubleClickHandler;
import com.sun.hotspot.igv.util.PropertiesConverter;
import com.sun.hotspot.igv.util.PropertiesSheet;
import com.sun.hotspot.igv.view.DiagramScene;
import java.awt.*;
@ -179,6 +180,8 @@ public class FigureWidget extends Widget implements Properties.Provider, PopupMe
}
};
node.setDisplayName(getName());
this.setToolTipText(PropertiesConverter.convertToHTML(f.getProperties()));
}
public Widget getLeftWidget() {