6837847: PKCS#11 A SecureRandom and a serialization error following installation of 1.5.0_18

Added a custom readObject method to PKCS11 SecureRandom impl

Reviewed-by: wetmore

jdk/src/share/classes/sun/security/pkcs11/P11SecureRandom.java

@@ -188,4 +188,13 @@ final class P11SecureRandom extends SecureRandomSpi {
             token.releaseSession(session);
         }
     }
+
+    private void readObject(ObjectInputStream in)
+            throws IOException, ClassNotFoundException {
+        in.defaultReadObject();
+        // assign default values to non-null transient fields
+        iBuffer = new byte[IBUFFER_SIZE];
+        ibuffered = 0;
+        lastRead = 0L;
+    }
 }

jdk/test/sun/security/pkcs11/SecureRandom/TestDeserialization.java

@@ -0,0 +1,94 @@
+/*
+ * Copyright 2010 Sun Microsystems, Inc.  All Rights Reserved.
+ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
+ *
+ * This code is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 only, as
+ * published by the Free Software Foundation.
+ *
+ * This code is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+ * version 2 for more details (a copy is included in the LICENSE file that
+ * accompanied this code).
+ *
+ * You should have received a copy of the GNU General Public License version
+ * 2 along with this work; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
+ *
+ * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
+ * CA 95054 USA or visit www.sun.com if you need additional information or
+ * have any questions.
+ */
+
+/**
+ * @test
+ * @bug 6837847
+ * @summary Ensure a deserialized PKCS#11 SecureRandom is functional.
+ * @library ..
+ */
+
+import java.security.*;
+import java.io.*;
+
+public class TestDeserialization extends PKCS11Test {
+
+    public void main(Provider p) throws Exception {
+        // Skip this test for providers not found by java.security.Security
+        if (Security.getProvider(p.getName()) != p) {
+            System.out.println("Skip test for provider " + p.getName());
+            return;
+        }
+        SecureRandom r;
+        try {
+            r = SecureRandom.getInstance("PKCS11", p);
+            System.out.println("SecureRandom instance " + r);
+        } catch (NoSuchAlgorithmException e) {
+            System.out.println("Provider " + p +
+                               " does not support SecureRandom, skipping");
+            e.printStackTrace();
+            return;
+        }
+        r.setSeed(System.currentTimeMillis());
+        byte[] buf = new byte[16];
+        byte[] ser = toByteArray(r);
+        System.out.println("Serialized Len = " + ser.length);
+        SecureRandom r2 = fromByteArray(ser);
+        System.out.println("Deserialized into " + r2);
+        r2.nextBytes(buf);
+        System.out.println("Done");
+    }
+
+    public static void main(String[] args) throws Exception {
+        main(new TestDeserialization());
+    }
+
+    private byte[] toByteArray(SecureRandom r) throws Exception {
+        ByteArrayOutputStream out = new ByteArrayOutputStream(1024);
+        ObjectOutputStream outStream = null;
+        try {
+            outStream = new ObjectOutputStream(out);
+            outStream.writeObject(r);
+            return out.toByteArray();
+        } finally {
+            if (outStream != null) {
+                outStream.close();
+            }
+        }
+    }
+
+    private SecureRandom fromByteArray(byte[] buf) throws Exception {
+        SecureRandom r = null;
+        ByteArrayInputStream is = new ByteArrayInputStream(buf);
+        ObjectInputStream ois = null;
+        try {
+            ois = new ObjectInputStream(is);
+            r = (SecureRandom) ois.readObject();
+        } finally {
+            if (ois != null) {
+                ois.close();
+            }
+        }
+        return r;
+    }
+}