infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-02-16 05:15:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

8033545: Missing volatile specifier in Bitmap::par_put_range_within_word

Browse Source 
The method Bitmap::par_put_range_within_word reloads the original value during a CAS, which may be optimized away. Instead of reloading, use the value returned by Atomic::cmpxchg_ptr() for further processing.

Reviewed-by: tschatzl, brutisso, tonyp
This commit is contained in:
Matthias Braun 2014-02-06 17:12:10 +01:00 committed by Thomas Schatzl
parent 0a63fe1c10
commit b109e793aa
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hotspot/src/share/vm/utilities/bitMap.cpp
View File

@ -107,7 +107,7 @@ void BitMap::par_put_range_within_word(idx_t beg, idx_t end, bool value) {
while (true) {
intptr_t res = Atomic::cmpxchg_ptr(nw, pw, w);
if (res == w) break;
w = *pw;
w = res;
nw = value ? (w | ~mr) : (w & mr);
}
}