infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 03:58:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

8376199

Browse Source 
Hi all,

  please review this change to convert usages of `AtomicAccess` to `Atomic<T>` in the `CodeCacheUnloadingTask` class.

Testing: gha

Thanks,
  Thomas
This commit is contained in:
Thomas Schatzl 2026-01-23 13:57:44 +01:00
parent 37cb22826a
commit b72ff712b2
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/hotspot/share/gc/shared/parallelCleaning.cpp
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2018, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -39,7 +39,7 @@ CodeCacheUnloadingTask::CodeCacheUnloadingTask(bool unloading_occurred) :
if(iter.next()) {
_first_nmethod = iter.method();
}
_claimed_nmethod = _first_nmethod;
_claimed_nmethod.store_relaxed(_first_nmethod);
}
CodeCacheUnloadingTask::~CodeCacheUnloadingTask() {
@ -53,7 +53,7 @@ void CodeCacheUnloadingTask::claim_nmethods(nmethod** claimed_nmethods, int *num
do {
*num_claimed_nmethods = 0;
first = _claimed_nmethod;
first = _claimed_nmethod.load_relaxed();
last = NMethodIterator(NMethodIterator::all, first);
if (first != nullptr) {
@ -67,7 +67,7 @@ void CodeCacheUnloadingTask::claim_nmethods(nmethod** claimed_nmethods, int *num
}
}
} while (AtomicAccess::cmpxchg(&_claimed_nmethod, first, last.method()) != first);
} while (!_claimed_nmethod.compare_set(first, last.method()));
}
void CodeCacheUnloadingTask::work(uint worker_id) {

5
src/hotspot/share/gc/shared/parallelCleaning.hpp
View File

@ -1,5 +1,5 @@
/*
* Copyright (c) 2018, 2025, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2018, 2026, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
@ -29,6 +29,7 @@
#include "code/codeCache.hpp"
#include "gc/shared/oopStorageParState.hpp"
#include "gc/shared/workerThread.hpp"
#include "runtime/atomic.hpp"
class CodeCacheUnloadingTask {
@ -36,7 +37,7 @@ class CodeCacheUnloadingTask {
// Variables used to claim nmethods.
nmethod* _first_nmethod;
nmethod* volatile _claimed_nmethod;
Atomic<nmethod*> _claimed_nmethod;
public:
CodeCacheUnloadingTask(bool unloading_occurred);