From b7cad91e1f11ee1f87b5fc4d17e7769e401eeb1a Mon Sep 17 00:00:00 2001 From: Sergey Bylokhov Date: Fri, 22 Nov 2013 17:02:49 +0400 Subject: [PATCH] 8028512: [macosx] Crash in full screen api if incorrect display mode is used Reviewed-by: anthony, leonidr --- .../macosx/classes/sun/awt/CGraphicsDevice.java | 14 +++++--------- jdk/src/macosx/native/sun/awt/AWTWindow.m | 8 ++++++-- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/jdk/src/macosx/classes/sun/awt/CGraphicsDevice.java b/jdk/src/macosx/classes/sun/awt/CGraphicsDevice.java index a3dc7e4cd27..22795f3c01e 100644 --- a/jdk/src/macosx/classes/sun/awt/CGraphicsDevice.java +++ b/jdk/src/macosx/classes/sun/awt/CGraphicsDevice.java @@ -158,12 +158,12 @@ public final class CGraphicsDevice extends GraphicsDevice boolean fsSupported = isFullScreenSupported(); if (fsSupported && old != null) { - // restore original display mode and enter windowed mode. + // enter windowed mode and restore original display mode + exitFullScreenExclusive(old); if (originalMode != null) { setDisplayMode(originalMode); originalMode = null; } - exitFullScreenExclusive(old); } super.setFullScreenWindow(w); @@ -227,14 +227,10 @@ public final class CGraphicsDevice extends GraphicsDevice throw new IllegalArgumentException("Invalid display mode"); } if (!Objects.equals(dm, getDisplayMode())) { - final Window w = getFullScreenWindow(); - if (w != null) { - exitFullScreenExclusive(w); - } nativeSetDisplayMode(displayID, dm.getWidth(), dm.getHeight(), - dm.getBitDepth(), dm.getRefreshRate()); - if (isFullScreenSupported() && w != null) { - enterFullScreenExclusive(w); + dm.getBitDepth(), dm.getRefreshRate()); + if (isFullScreenSupported() && getFullScreenWindow() != null) { + getFullScreenWindow().setSize(dm.getWidth(), dm.getHeight()); } } } diff --git a/jdk/src/macosx/native/sun/awt/AWTWindow.m b/jdk/src/macosx/native/sun/awt/AWTWindow.m index dcda6c3f9a8..f9a7919b4ef 100644 --- a/jdk/src/macosx/native/sun/awt/AWTWindow.m +++ b/jdk/src/macosx/native/sun/awt/AWTWindow.m @@ -1236,7 +1236,9 @@ JNF_COCOA_ENTER(env); NSRect screenRect = [[nsWindow screen] frame]; [nsWindow setFrame:screenRect display:YES]; } else { - [JNFException raise:env as:kRuntimeException reason:"Failed to enter full screen."]; + [JNFException raise:[ThreadUtilities getJNIEnv] + as:kRuntimeException + reason:"Failed to enter full screen."]; } }]; @@ -1261,7 +1263,9 @@ JNF_COCOA_ENTER(env); // GraphicsDevice takes care of restoring pre full screen bounds } else { - [JNFException raise:env as:kRuntimeException reason:"Failed to exit full screen."]; + [JNFException raise:[ThreadUtilities getJNIEnv] + as:kRuntimeException + reason:"Failed to exit full screen."]; } }];