infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-03-19 04:13:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

8025520: Array.prototype.slice should only copy defined elements

Browse Source 
Reviewed-by: sundar, lagergren
This commit is contained in:
Hannes Wallnöfer 2013-09-27 17:00:37 +02:00
parent 1240bd8a48
commit bf815f12fa
2 changed files with 55 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
nashorn/src/jdk/nashorn/internal/objects/NativeArray.java
View File

@ -860,9 +860,12 @@ public final class NativeArray extends ScriptObject {
return new NativeArray(sobj.getArray().slice(k, finale));
}
final NativeArray copy = new NativeArray(0);
// Construct array with proper length to have a deleted filter on undefined elements
final NativeArray copy = new NativeArray(finale - k);
for (long n = 0; k < finale; n++, k++) {
copy.defineOwnProperty(ArrayIndex.getArrayIndex(n), sobj.get(k));
if (sobj.has(k)) {
copy.defineOwnProperty(ArrayIndex.getArrayIndex(n), sobj.get(k));
}
}
return copy;

50
nashorn/test/script/basic/JDK-8025520.js Normal file
View File

@ -0,0 +1,50 @@
/*
* Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/**
* JDK-8025520: Array.prototype.slice should only copy defined elements
*
* @test
* @run
*/
var s = Array.prototype.slice.call({length: 6, 3: 1}, 2, 5);
if (s.length != 3) {
fail("s.length != 3");
}
if (0 in s) {
fail("0 in s");
}
if (s.hasOwnProperty(0)) {
fail("s.hasOwnProperty(0)");
}
if (s[1] !== 1) {
fail("s[1] !== 1");
}
if (2 in s) {
fail("2 in s");
}
if (s.hasOwnProperty(2)) {
fail("s.hasOwnProperty(2)");
}