infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-01-28 12:09:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

8249902: tools/javac/records/mandated_members/read_resolve_method/CheckReadResolveMethodTest.java uses @ignore w/o bug-id

Browse Source 
Reviewed-by: jjg
This commit is contained in:
Vicente Romero 2020-08-18 19:23:58 -04:00
parent 929ffca471
commit c2ee432602
1 changed files with 0 additions and 94 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

94
test/langtools/tools/javac/records/mandated_members/read_resolve_method/CheckReadResolveMethodTest.java
View File

@ -1,94 +0,0 @@
/*
* Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @summary check that members of abtract datum has protected access
* @ignore currently the compiler is generating a readResolve method but this test is failing now
* as the compiler will error if there is an explicit declaration of readResolve.
* @modules jdk.jdeps/com.sun.tools.classfile
* jdk.compiler/com.sun.tools.javac.util
* @compile CheckReadResolveMethodTest.java
* @run main CheckReadResolveMethodTest
*/
import java.io.*;
import com.sun.tools.classfile.*;
public class CheckReadResolveMethodTest {
// readResolve should be generated as a constructor is provided
record Point1(int i, int j) implements Serializable {
public Point1(int i, int j) {
this.i = i;
this.j = j;
}
}
// readResolve should be generated the record implements Serializable
record Point2(int i, int j) implements Serializable {}
// no readResolve should be generated as the record doesnt implement Serializable
record Point3(int i, int j) {}
// no readResolve should be generated as an implementation is already provided
record Point4(int i, int j) {
private Object readResolve() {
return new Point4(i, j);
}
}
// no readResolve should be generated as an implementation of readObject is already provided
record Point5(int i, int j) {
private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException {}
}
public static void main(String args[]) throws Throwable {
new CheckReadResolveMethodTest().run();
}
void run() throws Throwable {
checkReadResolveMethod("Point1", true);
checkReadResolveMethod("Point2", true);
checkReadResolveMethod("Point3", false);
checkReadResolveMethod("Point4", true);
checkReadResolveMethod("Point5", false);
}
void checkReadResolveMethod(String className, boolean shouldBeThere) throws Throwable {
File testClasses = new File(System.getProperty("test.classes"));
File file = new File(testClasses,
CheckReadResolveMethodTest.class.getName() + "$" + className +".class");
ClassFile classFile = ClassFile.read(file);
boolean found = false;
for (Method f : classFile.methods) {
if (f.getName(classFile.constant_pool).equals("readResolve")) {
found = true;
}
}
if (found != shouldBeThere) {
throw new AssertionError("incorrect generation of readResolve method at class " + className);
}
}
}