8264686: ClhsdbTestConnectArgument.java should use SATestUtils::validateSADebugDPrivileges

Reviewed-by: cjplummer
This commit is contained in:
Yasumasa Suenaga 2021-04-05 23:48:30 +00:00
parent b7baca7f32
commit c41cd1521f

View File

@ -44,18 +44,7 @@ public class ClhsdbTestConnectArgument {
public static void main(String[] args) throws Exception {
SATestUtils.skipIfCannotAttach(); // throws SkippedException if attach not expected to work.
if (SATestUtils.needsPrivileges()) {
// This tests has issues if you try adding privileges on OSX. The debugd process cannot
// be killed if you do this (because it is a root process and the test is not), so the destroy()
// call fails to do anything, and then waitFor() will time out. If you try to manually kill it with
// a "sudo kill" command, that seems to work, but then leaves the LingeredApp it was
// attached to in a stuck state for some unknown reason, causing the stopApp() call
// to timeout. For that reason we don't run this test when privileges are needed. Note
// it does appear to run fine as root, so we still allow it to run on OSX when privileges
// are not required.
throw new SkippedException("Cannot run this test on OSX if adding privileges is required.");
}
SATestUtils.validateSADebugDPrivileges();
System.out.println("Starting ClhsdbTestConnectArgument test");