infernap12/jdk
1
0
Fork 0
mirror of https://github.com/openjdk/jdk.git synced 2026-03-14 18:03:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

8359602: Ideal optimizations depending on input type are missed because of missing notification mechanism from CCP

Browse Source 
Reviewed-by: epeter, thartmann
This commit is contained in:
Benoît Maillard 2025-07-03 07:28:11 +00:00 committed by Emanuel Peter
parent fd13e1ce98
commit c75df634be
2 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/hotspot/share/opto/phaseX.cpp
View File

@ -3121,6 +3121,7 @@ Node *PhaseCCP::transform_once( Node *n ) {
hash_delete(n); // changing bottom type may force a rehash
n->raise_bottom_type(t);
_worklist.push(n); // n re-enters the hash table via the worklist
add_users_to_worklist(n); // if ideal or identity optimizations depend on the input type, users need to be notified
}
// TEMPORARY fix to ensure that 2nd GVN pass eliminates null checks

60
test/hotspot/jtreg/compiler/c2/TestModControlFoldedAfterCCP.java Normal file
View File

@ -0,0 +1,60 @@
/*
* Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/*
* @test
* @bug 8359602
* @summary The control input of a ModI node should be discarded if it is
* possible to prove that the divisor can never be 0.
* VerifyIterativeGVN checks that this optimization was applied
* @run main/othervm -XX:CompileCommand=quiet -XX:-TieredCompilation
* -XX:+UnlockDiagnosticVMOptions -Xcomp -XX:+IgnoreUnrecognizedVMOptions
* -XX:CompileCommand=compileonly,compiler.c2.TestModControlFoldedAfterCCP::test
* -XX:VerifyIterativeGVN=1110 compiler.c2.TestModControlFoldedAfterCCP
* @run main compiler.c2.TestModControlFoldedAfterCCP
*
*/
package compiler.c2;
public class TestModControlFoldedAfterCCP {
static void test() {
int i22, i24 = -1191, i28;
int iArr1[] = new int[1];
for (int i = 1;i < 100; i++) {
for (int j = 4; j > i; j--) {
i22 = i24;
// divisor is either -1191 or -13957
iArr1[0] = 5 % i22;
}
for (i28 = i; i28 < 2; ++i28) {
i24 = -13957;
}
}
}
public static void main(String[] args) {
test();
}
}